Patchwork [2/6] error: Trim includes in qerror.c

login
register
mail settings
Submitter Markus Armbruster
Date March 17, 2010, 5:56 p.m.
Message ID <1268848614-6844-3-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/47967/
State New
Headers show

Comments

Markus Armbruster - March 17, 2010, 5:56 p.m.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qerror.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Luiz Capitulino - March 18, 2010, 9:32 p.m.
On Wed, 17 Mar 2010 18:56:50 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qerror.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/qerror.c b/qerror.c
> index d0aba61..ff2fbd5 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -11,9 +11,7 @@
>   */
>  #include "qjson.h"
>  #include "qerror.h"
> -#include "qstring.h"
>  #include "qemu-common.h"
> -#include "qemu-error.h"

 Care to explain the reason? Are you relaying on the includes in qjson.h?

>  
>  static void qerror_destroy_obj(QObject *obj);
>
Markus Armbruster - March 19, 2010, 9:33 p.m.
Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Wed, 17 Mar 2010 18:56:50 +0100
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  qerror.c |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>> 
>> diff --git a/qerror.c b/qerror.c
>> index d0aba61..ff2fbd5 100644
>> --- a/qerror.c
>> +++ b/qerror.c
>> @@ -11,9 +11,7 @@
>>   */
>>  #include "qjson.h"
>>  #include "qerror.h"
>> -#include "qstring.h"
>>  #include "qemu-common.h"
>> -#include "qemu-error.h"
>
>  Care to explain the reason? Are you relaying on the includes in qjson.h?

qerror.h already includes them.

[...]
Luiz Capitulino - March 22, 2010, 12:38 a.m.
On Fri, 19 Mar 2010 22:33:29 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Wed, 17 Mar 2010 18:56:50 +0100
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> 
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >> ---
> >>  qerror.c |    2 --
> >>  1 files changed, 0 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/qerror.c b/qerror.c
> >> index d0aba61..ff2fbd5 100644
> >> --- a/qerror.c
> >> +++ b/qerror.c
> >> @@ -11,9 +11,7 @@
> >>   */
> >>  #include "qjson.h"
> >>  #include "qerror.h"
> >> -#include "qstring.h"
> >>  #include "qemu-common.h"
> >> -#include "qemu-error.h"
> >
> >  Care to explain the reason? Are you relaying on the includes in qjson.h?
> 
> qerror.h already includes them.

 Oh, okay then.

Patch

diff --git a/qerror.c b/qerror.c
index d0aba61..ff2fbd5 100644
--- a/qerror.c
+++ b/qerror.c
@@ -11,9 +11,7 @@ 
  */
 #include "qjson.h"
 #include "qerror.h"
-#include "qstring.h"
 #include "qemu-common.h"
-#include "qemu-error.h"
 
 static void qerror_destroy_obj(QObject *obj);