diff mbox

[RESEND,net] openvswitch: disable LRO

Message ID 5d7463bdfc32deb4c0b32ba7d9abf540fc6afed8.1433248445.git.jbenc@redhat.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Jiri Benc June 2, 2015, 12:36 p.m. UTC 
Currently, openvswitch tries to disable LRO from the user space. This does
not work correctly when the device added is a vlan interface, though.
Instead of dealing with possibly complex stacked cross name space relations
in the user space, do the same as bridging does and call dev_disable_lro in
the kernel.

Signed-off-by: Jiri Benc <jbenc@redhat.com>
Acked-by: Flavio Leitner <fbl@redhat.com>
Acked-by: Pravin B Shelar <pshelar@nicira.com>
---
Resending, the patch seems to be completely missing in patchwork.
---
 net/openvswitch/vport-netdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Miller June 4, 2015, 2:40 a.m. UTC | #1 
From: Jiri Benc <jbenc@redhat.com>
Date: Tue,  2 Jun 2015 14:36:34 +0200

> Currently, openvswitch tries to disable LRO from the user space. This does
> not work correctly when the device added is a vlan interface, though.
> Instead of dealing with possibly complex stacked cross name space relations
> in the user space, do the same as bridging does and call dev_disable_lro in
> the kernel.
> 
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
> Acked-by: Flavio Leitner <fbl@redhat.com>
> Acked-by: Pravin B Shelar <pshelar@nicira.com>
> ---
> Resending, the patch seems to be completely missing in patchwork.

Sorry about that, patchwork lost 22 hours of netdev postings and I tried to
pick up the slack with my inbox, but... things happen :)

Applied, thanks Jiri.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c
index 4776282c6417..33e6d6e2908f 100644
--- a/net/openvswitch/vport-netdev.c
+++ b/net/openvswitch/vport-netdev.c
@@ -125,6 +125,7 @@  static struct vport *netdev_create(const struct vport_parms *parms)
 	if (err)
 		goto error_master_upper_dev_unlink;
 
+	dev_disable_lro(netdev_vport->dev);
 	dev_set_promiscuity(netdev_vport->dev, 1);
 	netdev_vport->dev->priv_flags |= IFF_OVS_DATAPATH;
 	rtnl_unlock();