Patchwork [2/2] UBUNTU: [Config] enable BLK_DEV_BSG

login
register
mail settings
Submitter Andy Whitcroft
Date March 17, 2010, 9:26 a.m.
Message ID <1268817985-26172-3-git-send-email-apw@canonical.com>
Download mbox | patch
Permalink /patch/47921/
State Accepted
Delegated to: Andy Whitcroft
Headers show

Comments

Andy Whitcroft - March 17, 2010, 9:26 a.m.
Enable block layer SCSI Generic V4:

    BLK_DEV_BSG=y

This is an option which is recommended enabled, and seemingly required
for recent UDEV versions.  From the option's help text:

    This option is required by recent UDEV versions to properly
    access device serial numbers, etc.

    If unsure, say Y.

Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
 debian.master/config/config.common.ports  |    2 +-
 debian.master/config/config.common.ubuntu |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Stefan Bader - March 17, 2010, 9:36 a.m.
It was on our list (though a bit hidden) and has moved from experimental (for
which it was not enabled) to recommended. So it seem reasonable to turn it on now.

Andy Whitcroft wrote:
> Enable block layer SCSI Generic V4:
> 
>     BLK_DEV_BSG=y
> 
> This is an option which is recommended enabled, and seemingly required
> for recent UDEV versions.  From the option's help text:
> 
>     This option is required by recent UDEV versions to properly
>     access device serial numbers, etc.
> 
>     If unsure, say Y.
> 
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  debian.master/config/config.common.ports  |    2 +-
>  debian.master/config/config.common.ubuntu |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports
> index bfc858e..d9c2164 100644
> --- a/debian.master/config/config.common.ports
> +++ b/debian.master/config/config.common.ports
> @@ -272,7 +272,7 @@ CONFIG_BLK_DEV_3W_XXXX_RAID=m
>  # CONFIG_BLK_DEV_AEC62XX is not set
>  # CONFIG_BLK_DEV_ALI15X3 is not set
>  # CONFIG_BLK_DEV_AMD74XX is not set
> -# CONFIG_BLK_DEV_BSG is not set
> +CONFIG_BLK_DEV_BSG=y
>  # CONFIG_BLK_DEV_CMD64X is not set
>  CONFIG_BLK_DEV_COMPCACHE=m
>  # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 989c14c..d35c307 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -365,7 +365,7 @@ CONFIG_BLK_CPQ_CISS_DA=m
>  CONFIG_BLK_CPQ_DA=m
>  CONFIG_BLK_DEV=y
>  CONFIG_BLK_DEV_3W_XXXX_RAID=m
> -# CONFIG_BLK_DEV_BSG is not set
> +CONFIG_BLK_DEV_BSG=y
>  CONFIG_BLK_DEV_COMPCACHE=m
>  # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
>  # CONFIG_BLK_DEV_COMPCACHE_STATS is not set
Colin King - March 17, 2010, 10:10 a.m.
Well, this is no longer experimental and I cannot see any reason why not
to enable it, especially since the Kconfig recommends enabling it by
default.

On Wed, 2010-03-17 at 09:26 +0000, Andy Whitcroft wrote:
> Enable block layer SCSI Generic V4:
> 
>     BLK_DEV_BSG=y
> 
> This is an option which is recommended enabled, and seemingly required
> for recent UDEV versions.  From the option's help text:
> 
>     This option is required by recent UDEV versions to properly
>     access device serial numbers, etc.
> 
>     If unsure, say Y.
> 
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
Acked-by: Colin King <colin.king@canonical.com>

> ---
>  debian.master/config/config.common.ports  |    2 +-
>  debian.master/config/config.common.ubuntu |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports
> index bfc858e..d9c2164 100644
> --- a/debian.master/config/config.common.ports
> +++ b/debian.master/config/config.common.ports
> @@ -272,7 +272,7 @@ CONFIG_BLK_DEV_3W_XXXX_RAID=m
>  # CONFIG_BLK_DEV_AEC62XX is not set
>  # CONFIG_BLK_DEV_ALI15X3 is not set
>  # CONFIG_BLK_DEV_AMD74XX is not set
> -# CONFIG_BLK_DEV_BSG is not set
> +CONFIG_BLK_DEV_BSG=y
>  # CONFIG_BLK_DEV_CMD64X is not set
>  CONFIG_BLK_DEV_COMPCACHE=m
>  # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 989c14c..d35c307 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -365,7 +365,7 @@ CONFIG_BLK_CPQ_CISS_DA=m
>  CONFIG_BLK_CPQ_DA=m
>  CONFIG_BLK_DEV=y
>  CONFIG_BLK_DEV_3W_XXXX_RAID=m
> -# CONFIG_BLK_DEV_BSG is not set
> +CONFIG_BLK_DEV_BSG=y
>  CONFIG_BLK_DEV_COMPCACHE=m
>  # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
>  # CONFIG_BLK_DEV_COMPCACHE_STATS is not set
> -- 
> 1.7.0
> 
>

Patch

diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports
index bfc858e..d9c2164 100644
--- a/debian.master/config/config.common.ports
+++ b/debian.master/config/config.common.ports
@@ -272,7 +272,7 @@  CONFIG_BLK_DEV_3W_XXXX_RAID=m
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
-# CONFIG_BLK_DEV_BSG is not set
+CONFIG_BLK_DEV_BSG=y
 # CONFIG_BLK_DEV_CMD64X is not set
 CONFIG_BLK_DEV_COMPCACHE=m
 # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 989c14c..d35c307 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -365,7 +365,7 @@  CONFIG_BLK_CPQ_CISS_DA=m
 CONFIG_BLK_CPQ_DA=m
 CONFIG_BLK_DEV=y
 CONFIG_BLK_DEV_3W_XXXX_RAID=m
-# CONFIG_BLK_DEV_BSG is not set
+CONFIG_BLK_DEV_BSG=y
 CONFIG_BLK_DEV_COMPCACHE=m
 # CONFIG_BLK_DEV_COMPCACHE_DEBUG is not set
 # CONFIG_BLK_DEV_COMPCACHE_STATS is not set