diff mbox

[net] net/mlx4: double free of dev_vfs

Message ID 1433169704-32307-1-git-send-email-clsoto@linux.vnet.ibm.com
State Superseded, archived
Delegated to: David Miller
Headers show

Commit Message

clsoto@linux.vnet.ibm.com June 1, 2015, 2:41 p.m. UTC 
If user loads mlx4_core with num_vfs greater than supported
then variable dev->dev_vfs is freed 2 times after unloading
the driver.

Signed-off-by: Carol L Soto <clsoto@linux.vnet.ibm.com>
---
 drivers/net/ethernet/mellanox/mlx4/main.c |    1 +
 1 file changed, 1 insertion(+)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Or Gerlitz June 2, 2015, 7:25 a.m. UTC | #1 
On Mon, Jun 1, 2015 at 5:41 PM,  <clsoto@linux.vnet.ibm.com> wrote:
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -2685,6 +2685,7 @@ disable_sriov:
>  free_mem:
>         dev->persist->num_vfs = 0;
>         kfree(dev->dev_vfs);
> +       dev->dev_vfs = NULL;
>         return dev_flags & ~MLX4_FLAG_MASTER;
>  }

Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -2685,6 +2685,7 @@  disable_sriov:
 free_mem:
 	dev->persist->num_vfs = 0;
 	kfree(dev->dev_vfs);
+	dev->dev_vfs = NULL;
 	return dev_flags & ~MLX4_FLAG_MASTER;
 }