Patchwork qemu-io: fix aio help texts

login
register
mail settings
Submitter Christoph Hellwig
Date March 16, 2010, 6:12 p.m.
Message ID <20100316181258.GA10555@lst.de>
Download mbox | patch
Permalink /patch/47887/
State New
Headers show

Comments

Christoph Hellwig - March 16, 2010, 6:12 p.m.
Fix a few typos in the helptexts for the various aio commands.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Aurelien Jarno - March 27, 2010, 12:33 p.m.
On Tue, Mar 16, 2010 at 07:12:58PM +0100, Christoph Hellwig wrote:
> Fix a few typos in the helptexts for the various aio commands.

This is clearly an improvement, but it introduces a typo (see below).

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: qemu/qemu-io.c
> ===================================================================
> --- qemu.orig/qemu-io.c	2010-03-16 19:07:43.089009269 +0100
> +++ qemu/qemu-io.c	2010-03-16 19:08:36.597005148 +0100
> @@ -904,8 +904,8 @@ aio_read_help(void)
>  "\n"
>  " Reads a segment of the currently open file, optionally dumping it to the\n"
>  " standard output stream (with -v option) for subsequent inspection.\n"
> -" The read is performed asynchronously and should the aio_flush command \n"
> -" should be used to ensure all outstanding aio requests have been completed\n"
> +" The read is performed asynchronously and the aio_flush command must be\n"

"used" is missing here.

> +" to ensure all outstanding aio requests have been completed\n"
>  " -C, -- report statistics in a machine parsable format\n"
>  " -P, -- use a pattern to verify read data\n"
>  " -v, -- dump buffer to standard output\n"
> @@ -1003,8 +1003,8 @@ aio_write_help(void)
>  "\n"
>  " Writes into a segment of the currently open file, using a buffer\n"
>  " filled with a set pattern (0xcdcdcdcd).\n"
> -" The write is performed asynchronously and should the aio_flush command \n"
> -" should be used to ensure all outstanding aio requests have been completed\n"
> +" The write is performed asynchronously and the aio_flush command must be\n"
> +" used to ensure all outstanding aio requests have been completed\n"
>  " -P, -- use different pattern to fill file\n"
>  " -C, -- report statistics in a machine parsable format\n"
>  " -q, -- quite mode, do not show I/O statistics\n"
> @@ -1095,7 +1095,7 @@ aio_flush_f(int argc, char **argv)
>  static const cmdinfo_t aio_flush_cmd = {
>  	.name		= "aio_flush",
>  	.cfunc		= aio_flush_f,
> -	.oneline	= "completes all outstanding aio requets"
> +	.oneline	= "completes all outstanding aio requests"
>  };
>  
>  static int
> 
> 
>

Patch

Index: qemu/qemu-io.c
===================================================================
--- qemu.orig/qemu-io.c	2010-03-16 19:07:43.089009269 +0100
+++ qemu/qemu-io.c	2010-03-16 19:08:36.597005148 +0100
@@ -904,8 +904,8 @@  aio_read_help(void)
 "\n"
 " Reads a segment of the currently open file, optionally dumping it to the\n"
 " standard output stream (with -v option) for subsequent inspection.\n"
-" The read is performed asynchronously and should the aio_flush command \n"
-" should be used to ensure all outstanding aio requests have been completed\n"
+" The read is performed asynchronously and the aio_flush command must be\n"
+" to ensure all outstanding aio requests have been completed\n"
 " -C, -- report statistics in a machine parsable format\n"
 " -P, -- use a pattern to verify read data\n"
 " -v, -- dump buffer to standard output\n"
@@ -1003,8 +1003,8 @@  aio_write_help(void)
 "\n"
 " Writes into a segment of the currently open file, using a buffer\n"
 " filled with a set pattern (0xcdcdcdcd).\n"
-" The write is performed asynchronously and should the aio_flush command \n"
-" should be used to ensure all outstanding aio requests have been completed\n"
+" The write is performed asynchronously and the aio_flush command must be\n"
+" used to ensure all outstanding aio requests have been completed\n"
 " -P, -- use different pattern to fill file\n"
 " -C, -- report statistics in a machine parsable format\n"
 " -q, -- quite mode, do not show I/O statistics\n"
@@ -1095,7 +1095,7 @@  aio_flush_f(int argc, char **argv)
 static const cmdinfo_t aio_flush_cmd = {
 	.name		= "aio_flush",
 	.cfunc		= aio_flush_f,
-	.oneline	= "completes all outstanding aio requets"
+	.oneline	= "completes all outstanding aio requests"
 };
 
 static int