diff mbox

Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

Message ID CAMe9rOoab-4t3O6Bd-PPhp82YHeNQME9ipCKfgERMKtQOvGPBg@mail.gmail.com
State New
Headers show

Commit Message

H.J. Lu May 31, 2015, 12:08 p.m. UTC 
On Sun, May 31, 2015 at 12:04 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> configure:28726: checking for -fno-PIE option
> configure:28737: g++ -c -g   conftest.cpp >&5
> configure:28737: $? = 0
> configure:28745: result: yes

Since GCC is written in C++ now, we need to check CXXFLAGS instead of CFLAGS
for NO_PIE_CFLAGS.  I checked it in as an obvious fix.

Thanks.
diff mbox

Patch

Index: ChangeLog
===================================================================
--- ChangeLog (revision 223898)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@ 
+2015-05-31  H.J. Lu  <hongjiu.lu@intel.com>
+
+ * configure.ac (NO_PIE_CFLAGS): Check CXXFLAGS instead of CFLAGS.
+ * configure: Regenerated.
+
 2015-05-31  Mikhail Maltsev  <maltsevm@gmail.com>

  * config/cris/cris.h (CRIS_ARCH_CPP_DEFAULT): Fix C++11 compatibility
Index: configure
===================================================================
--- configure (revision 223898)
+++ configure (working copy)
@@ -28728,8 +28728,8 @@  $as_echo_n "checking for -fno-PIE option
 if test "${gcc_cv_c_no_fpie+set}" = set; then :
   $as_echo_n "(cached) " >&6
 else
-  saved_CFLAGS="$CFLAGS"
-   CFLAGS="$CFLAGS -fno-PIE"
+  saved_CXXFLAGS="$CXXFLAGS"
+   CXXFLAGS="$CXXFLAGS -fno-PIE"
    cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 int main(void) {return 0;}
@@ -28740,7 +28740,7 @@  else
   gcc_cv_c_no_fpie=no
 fi
 rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
-   CFLAGS="$saved_CFLAGS"
+   CXXFLAGS="$saved_CXXFLAGS"
 fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_c_no_fpie" >&5
 $as_echo "$gcc_cv_c_no_fpie" >&6; }
Index: configure.ac
===================================================================
--- configure.ac (revision 223898)
+++ configure.ac (working copy)
@@ -5834,12 +5834,12 @@  AC_SUBST([enable_default_pie])
 # Check if -fno-PIE works.
 AC_CACHE_CHECK([for -fno-PIE option],
   [gcc_cv_c_no_fpie],
-  [saved_CFLAGS="$CFLAGS"
-   CFLAGS="$CFLAGS -fno-PIE"
+  [saved_CXXFLAGS="$CXXFLAGS"
+   CXXFLAGS="$CXXFLAGS -fno-PIE"
    AC_COMPILE_IFELSE([int main(void) {return 0;}],
      [gcc_cv_c_no_fpie=yes],
      [gcc_cv_c_no_fpie=no])
-   CFLAGS="$saved_CFLAGS"])
+   CXXFLAGS="$saved_CXXFLAGS"])
 if test "$gcc_cv_c_no_fpie" = "yes"; then
   NO_PIE_CFLAGS="-fno-PIE"
 fi