Patchwork [1/4] tcg-hppa: Fix const errors in hppa-dis.c.

login
register
mail settings
Submitter Richard Henderson
Date Feb. 20, 2010, 7:31 p.m.
Message ID <18ee2942b84aa4df1d25cc8bda2cab311f142b23.1268754659.git.rth@twiddle.net>
Download mbox | patch
Permalink /patch/47863/
State New
Headers show

Comments

Richard Henderson - Feb. 20, 2010, 7:31 p.m.
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 hppa-dis.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Stuart Brady - March 17, 2010, 1:46 a.m.
On Sat, Feb 20, 2010 at 11:31:31AM -0800, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>

Acked-by: Stuart Brady <stuart.brady@gmail.com>

> ---
>  hppa-dis.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hppa-dis.c b/hppa-dis.c
> index 9d96d72..49f99c8 100644
> --- a/hppa-dis.c
> +++ b/hppa-dis.c
> @@ -576,7 +576,7 @@ struct pa_opcode
>      const char *name;
>      unsigned long int match;	/* Bits that must be set...  */
>      unsigned long int mask;	/* ... in these bits. */
> -    char *args;
> +    const char *args;
>      enum pa_arch arch;
>      char flags;
>  };
> @@ -2753,7 +2753,7 @@ print_insn_hppa (bfd_vma memaddr, disassemble_info *info)
>  		    int sf = GET_FIELD (insn, 19, 20);
>  		    const char * const * source = float_format_names;
>  		    const char * const * dest = float_format_names;
> -		    char *t = "";
> +		    const char *t = "";
>  
>  		    if (sub == 4)
>  		      {
> -- 
> 1.6.6.1
> 
>
Aurelien Jarno - March 23, 2010, 9:26 p.m.
On Sat, Feb 20, 2010 at 11:31:31AM -0800, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>

Thanks, applied.

> ---
>  hppa-dis.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hppa-dis.c b/hppa-dis.c
> index 9d96d72..49f99c8 100644
> --- a/hppa-dis.c
> +++ b/hppa-dis.c
> @@ -576,7 +576,7 @@ struct pa_opcode
>      const char *name;
>      unsigned long int match;	/* Bits that must be set...  */
>      unsigned long int mask;	/* ... in these bits. */
> -    char *args;
> +    const char *args;
>      enum pa_arch arch;
>      char flags;
>  };
> @@ -2753,7 +2753,7 @@ print_insn_hppa (bfd_vma memaddr, disassemble_info *info)
>  		    int sf = GET_FIELD (insn, 19, 20);
>  		    const char * const * source = float_format_names;
>  		    const char * const * dest = float_format_names;
> -		    char *t = "";
> +		    const char *t = "";
>  
>  		    if (sub == 4)
>  		      {
> -- 
> 1.6.6.1
> 
> 
> 
>

Patch

diff --git a/hppa-dis.c b/hppa-dis.c
index 9d96d72..49f99c8 100644
--- a/hppa-dis.c
+++ b/hppa-dis.c
@@ -576,7 +576,7 @@  struct pa_opcode
     const char *name;
     unsigned long int match;	/* Bits that must be set...  */
     unsigned long int mask;	/* ... in these bits. */
-    char *args;
+    const char *args;
     enum pa_arch arch;
     char flags;
 };
@@ -2753,7 +2753,7 @@  print_insn_hppa (bfd_vma memaddr, disassemble_info *info)
 		    int sf = GET_FIELD (insn, 19, 20);
 		    const char * const * source = float_format_names;
 		    const char * const * dest = float_format_names;
-		    char *t = "";
+		    const char *t = "";
 
 		    if (sub == 4)
 		      {