diff mbox

[U-Boot,2/3] mtd: OMAP: Enable GPMC prefetch mode for 16 bit access

Message ID 1432973485-4030-3-git-send-email-jeroen@myspectrum.nl
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Jeroen Hofstee May 30, 2015, 8:11 a.m. UTC 
commit c316f57 "mtd: OMAP: Enable GPMC prefetch mode" only enabled
prefetch mode for 8 bit nand access, this adds 16 bit as well.

Cc: Scott Wood <scottwood@freescale.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: Daniel Mack <zonque@gmail.com>

Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
 drivers/mtd/nand/omap_gpmc.c | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)

Comments

Tom Rini June 2, 2015, 5:13 p.m. UTC | #1 
On Sat, May 30, 2015 at 10:11:24AM +0200, Jeroen Hofstee wrote:

> commit c316f57 "mtd: OMAP: Enable GPMC prefetch mode" only enabled
> prefetch mode for 8 bit nand access, this adds 16 bit as well.
> 
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Daniel Mack <zonque@gmail.com>
> 
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini June 18, 2015, 10:45 p.m. UTC | #2 
On Sat, May 30, 2015 at 10:11:24AM +0200, Jeroen Hofstee wrote:

> commit c316f57 "mtd: OMAP: Enable GPMC prefetch mode" only enabled
> prefetch mode for 8 bit nand access, this adds 16 bit as well.
> 
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Daniel Mack <zonque@gmail.com>
> 
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
index de90d55..4372988 100644
--- a/drivers/mtd/nand/omap_gpmc.c
+++ b/drivers/mtd/nand/omap_gpmc.c
@@ -415,7 +415,17 @@  static int __read_prefetch_aligned(struct nand_chip *chip, uint32_t *buf, int le
 	return 0;
 }
 
-static void omap_nand_read_prefetch8(struct mtd_info *mtd, uint8_t *buf, int len)
+static inline void omap_nand_read(struct mtd_info *mtd, uint8_t *buf, int len)
+{
+	struct nand_chip *chip = mtd->priv;
+
+	if (chip->options & NAND_BUSWIDTH_16)
+		nand_read_buf16(mtd, buf, len);
+	else
+		nand_read_buf(mtd, buf, len);
+}
+
+static void omap_nand_read_prefetch(struct mtd_info *mtd, uint8_t *buf, int len)
 {
 	int ret;
 	uint32_t head, tail;
@@ -427,7 +437,7 @@  static void omap_nand_read_prefetch8(struct mtd_info *mtd, uint8_t *buf, int len
 	 */
 	head = ((uint32_t) buf) % 4;
 	if (head) {
-		nand_read_buf(mtd, buf, head);
+		omap_nand_read(mtd, buf, head);
 		buf += head;
 		len -= head;
 	}
@@ -438,13 +448,13 @@  static void omap_nand_read_prefetch8(struct mtd_info *mtd, uint8_t *buf, int len
 	 */
 	tail = len % 4;
 
-	ret = __read_prefetch_aligned(chip, (uint32_t *) buf, len - tail);
+	ret = __read_prefetch_aligned(chip, (uint32_t *)buf, len - tail);
 	if (ret < 0) {
 		/* fallback in case the prefetch engine is busy */
-		nand_read_buf(mtd, buf, len);
+		omap_nand_read(mtd, buf, len);
 	} else if (tail) {
 		buf += len - tail;
-		nand_read_buf(mtd, buf, tail);
+		omap_nand_read(mtd, buf, tail);
 	}
 }
 #endif /* CONFIG_NAND_OMAP_GPMC_PREFETCH */
@@ -1011,13 +1021,11 @@  int board_nand_init(struct nand_chip *nand)
 	if (err)
 		return err;
 
-	/* TODO: Implement for 16-bit bus width */
-	if (nand->options & NAND_BUSWIDTH_16)
-		nand->read_buf = nand_read_buf16;
 #ifdef CONFIG_NAND_OMAP_GPMC_PREFETCH
-	else
-		nand->read_buf = omap_nand_read_prefetch8;
+	nand->read_buf = omap_nand_read_prefetch;
 #else
+	if (nand->options & NAND_BUSWIDTH_16)
+		nand->read_buf = nand_read_buf16;
 	else
 		nand->read_buf = nand_read_buf;
 #endif