diff mbox

[v3,14/21] monitor: Limit QError use to command handlers

Message ID 87y4k7v4w4.fsf@blackfin.pond.sub.org
State New
Headers show

Commit Message

Markus Armbruster May 29, 2015, 2:23 p.m. UTC 
The following hunk needs to be squashed in:

Comments

Luiz Capitulino May 29, 2015, 2:27 p.m. UTC | #1 
On Fri, 29 May 2015 16:23:55 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> The following hunk needs to be squashed in:
> 
> diff --git a/monitor.c b/monitor.c
> index 16bd567..888d771 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -5005,7 +5005,6 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
>          goto err_out;
>      }
>      if (invalid_qmp_mode(mon, cmd, &local_err)) {
> -        qerror_report_err(local_err);
>          goto err_out;
>      }

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

>  
>
diff mbox

Patch

diff --git a/monitor.c b/monitor.c
index 16bd567..888d771 100644
--- a/monitor.c
+++ b/monitor.c
@@ -5005,7 +5005,6 @@  static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
         goto err_out;
     }
     if (invalid_qmp_mode(mon, cmd, &local_err)) {
-        qerror_report_err(local_err);
         goto err_out;
     }