diff mbox

[net-next] qla4xxx: add a missing include

Message ID 1432701824.4060.346.camel@edumazet-glaptop2.roam.corp.google.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Eric Dumazet May 27, 2015, 4:43 a.m. UTC 
From: Eric Dumazet <edumzet@google.com>

vmalloc.h used to be included from include/net/inet_hashtables.h
but it is no longer the case.

Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Eric Dumazet <edumzet@google.com>
---
Given its broken in David net-next tree, its probably simpler
that David merges this fix directly ? Thanks !

 drivers/scsi/qla4xxx/ql4_def.h |    1 +
 1 file changed, 1 insertion(+)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller May 27, 2015, 6:21 p.m. UTC | #1 
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 26 May 2015 21:43:44 -0700

> From: Eric Dumazet <edumzet@google.com>
> 
> vmalloc.h used to be included from include/net/inet_hashtables.h
> but it is no longer the case.
> 
> Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()")
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Eric Dumazet <edumzet@google.com>
> ---
> Given its broken in David net-next tree, its probably simpler
> that David merges this fix directly ? Thanks !

Yeah it's easiest if I just apply this to net-next, which I've just done,
thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
James Bottomley May 27, 2015, 6:33 p.m. UTC | #2 
On Wed, 2015-05-27 at 14:21 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 26 May 2015 21:43:44 -0700
> 
> > From: Eric Dumazet <edumzet@google.com>
> > 
> > vmalloc.h used to be included from include/net/inet_hashtables.h
> > but it is no longer the case.
> > 
> > Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()")
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Signed-off-by: Eric Dumazet <edumzet@google.com>
> > ---
> > Given its broken in David net-next tree, its probably simpler
> > that David merges this fix directly ? Thanks !
> 
> Yeah it's easiest if I just apply this to net-next, which I've just done,
> thanks Eric.

Fine with me.  There's no point creating cross tree hassle for a simple
include problem.

James



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Dumazet May 27, 2015, 7:47 p.m. UTC | #3 
On Wed, 2015-05-27 at 11:33 -0700, James Bottomley wrote:
> On Wed, 2015-05-27 at 14:21 -0400, David Miller wrote:

> > Yeah it's easiest if I just apply this to net-next, which I've just done,
> > thanks Eric.
> 
> Fine with me.  There's no point creating cross tree hassle for a simple
> include problem.

Note there are other drivers to fix, I'll try to submit patches for
them.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/scsi/qla4xxx/ql4_def.h b/drivers/scsi/qla4xxx/ql4_def.h
index 8f6d0fb2cd807255a66e962c3cb7c4c8633d4d77..a7cfc270bd08a1f01867affc2dee0fc6b7611472 100644
--- a/drivers/scsi/qla4xxx/ql4_def.h
+++ b/drivers/scsi/qla4xxx/ql4_def.h
@@ -26,6 +26,7 @@ 
 #include <linux/mutex.h>
 #include <linux/aer.h>
 #include <linux/bsg-lib.h>
+#include <linux/vmalloc.h>
 
 #include <net/tcp.h>
 #include <scsi/scsi.h>