Patchwork spelling typo (compatibilty) in hw/fw_cfg.c

login
register
mail settings
Submitter Vagrant Cascadian
Date March 12, 2010, 6:26 p.m.
Message ID <20100312182633.GC8032@claws.fglan>
Download mbox | patch
Permalink /patch/47685/
State New
Headers show

Comments

Vagrant Cascadian - March 12, 2010, 6:26 p.m.
here's a trivial patch to fix the spelling of "compatibility":


i found this spelling typo and the previous one by running lintian on the qemu
packages i work on for debian:

http://lintian.debian.org/full/pkg-qemu-devel@lists.alioth.debian.org.html#qemu

live well,
  vagrant
Blue Swirl - March 13, 2010, 11:05 a.m.
On 3/12/10, Vagrant Cascadian <vagrant@freegeek.org> wrote:
> here's a trivial patch to fix the spelling of "compatibility":

Please add a Signed-off-by: line.

>
>  diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c
>  index fe6c543..22ebb50 100644
>  --- a/hw/fw_cfg.c
>  +++ b/hw/fw_cfg.c
>  @@ -179,7 +179,7 @@ static int get_uint32_as_uint16(QEMUFile *f, void *pv, size_t size)
>
>   static void put_unused(QEMUFile *f, void *pv, size_t size)
>   {
>  -    fprintf(stderr, "uint32_as_uint16 is only used for backward compatibilty.\n");
>  +    fprintf(stderr, "uint32_as_uint16 is only used for backward compatibility.\n");
>      fprintf(stderr, "This functions shouldn't be called.\n");
>   }
>
>
>  i found this spelling typo and the previous one by running lintian on the qemu
>  packages i work on for debian:
>
>  http://lintian.debian.org/full/pkg-qemu-devel@lists.alioth.debian.org.html#qemu

Perhaps the manual page errors should be fixed too,
Vagrant Cascadian - March 13, 2010, 9:38 p.m.
On Sat, Mar 13, 2010 at 01:05:03PM +0200, Blue Swirl wrote:
> On 3/12/10, Vagrant Cascadian <vagrant@freegeek.org> wrote:
> >  i found this spelling typo and the previous one by running lintian on the qemu
> >  packages i work on for debian:
> >
> >  http://lintian.debian.org/full/pkg-qemu-devel@lists.alioth.debian.org.html#qemu
>
> Perhaps the manual page errors should be fixed too,

i did look into that a bit, though it is a little tricky because it's got the
qemu-doc.texi and qemu-options.texi (texinfo?) layer of abstraction. for the
full details:

  LANG=C MANWIDTH=80 man --warnings -E UTF-8 -l ./qemu.1 >/dev/null
  <standard input>:730: warning [p 9, 4.8i, div `an-div', 0.2i]: can't break line
  <standard input>:730: warning [p 9, 5.0i]: can't break line
  <standard input>:735: warning [p 9, 5.8i, div `an-div', 0.2i]: can't break line
  <standard input>:735: warning [p 9, 6.0i]: can't break line
  <standard input>:869: warning [p 11, 5.2i, div `an-div', 0.2i]: can't break line
  <standard input>:869: warning [p 11, 5.3i]: can't break line
  <standard input>:890: warning [p 11, 8.3i, div `an-div', 0.2i]: can't break line
  <standard input>:890: warning [p 11, 8.5i]: can't break line
  <standard input>:953: warning [p 12, 5.8i, div `an-div', 0.2i]: can't break line
  <standard input>:953: warning [p 12, 6.0i]: can't break line
  <standard input>:1732: warning [p 22, 1.8i, div `an-div', 0.2i]: can't break line
  <standard input>:1732: warning [p 22, 2.0i]: can't break line
  
the generated manpage has several lines longer than 80 characters describing
commandline arguments, such as:

       -smbios
       type=1[,manufacturer=str][,product=str][,version=str][,serial=str][,uuid=uuid][,sku=str][,family=str]
           Specify SMBIOS type 1 fields
...
       -net
       nic[,vlan=n][,macaddr=mac][,model=type][,name=name][,addr=addr][,vectors=v]

and so on...

i don't know if there is a way to more succinctly describe those options that
gets all the details... or an easy way to generate the manpage to fix the
formatting issues with those long lines.

live well,
  vagrant
Vagrant Cascadian - March 13, 2010, 9:38 p.m.
On Sat, Mar 13, 2010 at 01:05:03PM +0200, Blue Swirl wrote:
> On 3/12/10, Vagrant Cascadian <vagrant@freegeek.org> wrote:
> > here's a trivial patch to fix the spelling of "compatibility":
> 
> Please add a Signed-off-by: line.

hope this is what you're looking for:

Signed-off-by: Vagrant Cascadian <vagrant@freegeek.org>

> >
> >  diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c
> >  index fe6c543..22ebb50 100644
> >  --- a/hw/fw_cfg.c
> >  +++ b/hw/fw_cfg.c
> >  @@ -179,7 +179,7 @@ static int get_uint32_as_uint16(QEMUFile *f, void *pv, size_t size)
> >
> >   static void put_unused(QEMUFile *f, void *pv, size_t size)
> >   {
> >  -    fprintf(stderr, "uint32_as_uint16 is only used for backward compatibilty.\n");
> >  +    fprintf(stderr, "uint32_as_uint16 is only used for backward compatibility.\n");
> >      fprintf(stderr, "This functions shouldn't be called.\n");
> >   }

live well,
  vagrant
Blue Swirl - March 14, 2010, 8:54 a.m.
On 3/13/10, Vagrant Cascadian <vagrant@freegeek.org> wrote:
> On Sat, Mar 13, 2010 at 01:05:03PM +0200, Blue Swirl wrote:
>  > On 3/12/10, Vagrant Cascadian <vagrant@freegeek.org> wrote:
>  > > here's a trivial patch to fix the spelling of "compatibility":
>  >
>  > Please add a Signed-off-by: line.
>
>
> hope this is what you're looking for:
>
>  Signed-off-by: Vagrant Cascadian <vagrant@freegeek.org>

Yes. Thanks, applied.

Patch

diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c
index fe6c543..22ebb50 100644
--- a/hw/fw_cfg.c
+++ b/hw/fw_cfg.c
@@ -179,7 +179,7 @@  static int get_uint32_as_uint16(QEMUFile *f, void *pv, size_t size)

 static void put_unused(QEMUFile *f, void *pv, size_t size)
 {
-    fprintf(stderr, "uint32_as_uint16 is only used for backward compatibilty.\n");
+    fprintf(stderr, "uint32_as_uint16 is only used for backward compatibility.\n");
     fprintf(stderr, "This functions shouldn't be called.\n");
 }