Patchwork [07/13] RDS: Workaround for in-use MRs on close causing crash

login
register
mail settings
Submitter Andy Grover
Date March 11, 2010, 11:50 p.m.
Message ID <1268351407-7394-8-git-send-email-andy.grover@oracle.com>
Download mbox | patch
Permalink /patch/47650/
State Accepted
Delegated to: David Miller
Headers show

Comments

Andy Grover - March 11, 2010, 11:50 p.m.
if a machine is shut down without closing sockets properly, and
freeing all MRs, then a BUG_ON will bring it down. This patch
changes these to WARN_ONs -- leaking MRs is not fatal (although
not ideal, and there is more work to do here for a proper fix.)

Signed-off-by: Andy Grover <andy.grover@oracle.com>
---
 net/rds/ib_rdma.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
index 4b0da86..65e668d 100644
--- a/net/rds/ib_rdma.c
+++ b/net/rds/ib_rdma.c
@@ -234,8 +234,8 @@  void rds_ib_destroy_mr_pool(struct rds_ib_mr_pool *pool)
 {
 	flush_workqueue(rds_wq);
 	rds_ib_flush_mr_pool(pool, 1);
-	BUG_ON(atomic_read(&pool->item_count));
-	BUG_ON(atomic_read(&pool->free_pinned));
+	WARN_ON(atomic_read(&pool->item_count));
+	WARN_ON(atomic_read(&pool->free_pinned));
 	kfree(pool);
 }