From patchwork Thu Mar 11 22:07:49 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [1/5] phonet: use for_each_set_bit() Date: Thu, 11 Mar 2010 12:07:49 -0000 From: Andrew Morton X-Patchwork-Id: 47639 Message-Id: <201003112207.o2BM7nQn013486@imap1.linux-foundation.org> To: davem@davemloft.net Cc: netdev@vger.kernel.org, akpm@linux-foundation.org, akinobu.mita@gmail.com From: Akinobu Mita Replace open-coded loop with for_each_set_bit(). Signed-off-by: Akinobu Mita Cc: "David S. Miller" Signed-off-by: Andrew Morton Acked-by: Rémi Denis-Courmont --- net/phonet/pn_dev.c | 3 +-- net/phonet/pn_netlink.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff -puN net/phonet/pn_dev.c~phonet-use-for_each_set_bit net/phonet/pn_dev.c --- a/net/phonet/pn_dev.c~phonet-use-for_each_set_bit +++ a/net/phonet/pn_dev.c @@ -107,8 +107,7 @@ static void phonet_device_destroy(struct if (pnd) { u8 addr; - for (addr = find_first_bit(pnd->addrs, 64); addr < 64; - addr = find_next_bit(pnd->addrs, 64, 1+addr)) + for_each_set_bit(addr, pnd->addrs, 64) phonet_address_notify(RTM_DELADDR, dev, addr); kfree(pnd); } diff -puN net/phonet/pn_netlink.c~phonet-use-for_each_set_bit net/phonet/pn_netlink.c --- a/net/phonet/pn_netlink.c~phonet-use-for_each_set_bit +++ a/net/phonet/pn_netlink.c @@ -141,8 +141,7 @@ static int getaddr_dumpit(struct sk_buff continue; addr_idx = 0; - for (addr = find_first_bit(pnd->addrs, 64); addr < 64; - addr = find_next_bit(pnd->addrs, 64, 1+addr)) { + for_each_set_bit(addr, pnd->addrs, 64) { if (addr_idx++ < addr_start_idx) continue;