[RFC] KVM: PPC: fix suspicious use of conditional operator

Submitted by Tudor Laurentiu on May 22, 2015, 2:46 p.m.

Details

Message ID 555F4141.8090107@freescale.com
State New
Headers show

Commit Message

Tudor Laurentiu May 22, 2015, 2:46 p.m.
This was signaled by a static code analysis tool.

Signed-off-by: Laurentiu Tudor <Laurentiu.Tudor@freescale.com>
---
 arch/powerpc/kvm/e500_mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Scott Wood May 22, 2015, 7:20 p.m.
On Fri, 2015-05-22 at 17:46 +0300, Laurentiu Tudor wrote:
> This was signaled by a static code analysis tool.
> 
> Signed-off-by: Laurentiu Tudor <Laurentiu.Tudor@freescale.com>
> ---
>  arch/powerpc/kvm/e500_mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kvm/e500_mmu.c b/arch/powerpc/kvm/e500_mmu.c
> index 50860e9..29911a0 100644
> --- a/arch/powerpc/kvm/e500_mmu.c
> +++ b/arch/powerpc/kvm/e500_mmu.c
> @@ -377,7 +377,7 @@ int kvmppc_e500_emul_tlbsx(struct kvm_vcpu *vcpu, gva_t ea)
>  			| MAS0_NV(vcpu_e500->gtlb_nv[tlbsel]);
>  		vcpu->arch.shared->mas1 =
>  			  (vcpu->arch.shared->mas6 & MAS6_SPID0)
> -			| (vcpu->arch.shared->mas6 & (MAS6_SAS ? MAS1_TS : 0))
> +			| ((vcpu->arch.shared->mas6 & MAS6_SAS) ? MAS1_TS : 0)
>  			| (vcpu->arch.shared->mas4 & MAS4_TSIZED(~0));
>  		vcpu->arch.shared->mas2 &= MAS2_EPN;
>  		vcpu->arch.shared->mas2 |= vcpu->arch.shared->mas4 &

Reviewed-by: Scott Wood <scottwood@freescale.com>

Please send as non-RFC.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/arch/powerpc/kvm/e500_mmu.c b/arch/powerpc/kvm/e500_mmu.c
index 50860e9..29911a0 100644
--- a/arch/powerpc/kvm/e500_mmu.c
+++ b/arch/powerpc/kvm/e500_mmu.c
@@ -377,7 +377,7 @@  int kvmppc_e500_emul_tlbsx(struct kvm_vcpu *vcpu, gva_t ea)
 			| MAS0_NV(vcpu_e500->gtlb_nv[tlbsel]);
 		vcpu->arch.shared->mas1 =
 			  (vcpu->arch.shared->mas6 & MAS6_SPID0)
-			| (vcpu->arch.shared->mas6 & (MAS6_SAS ? MAS1_TS : 0))
+			| ((vcpu->arch.shared->mas6 & MAS6_SAS) ? MAS1_TS : 0)
 			| (vcpu->arch.shared->mas4 & MAS4_TSIZED(~0));
 		vcpu->arch.shared->mas2 &= MAS2_EPN;
 		vcpu->arch.shared->mas2 |= vcpu->arch.shared->mas4 &