| Message ID | 1432144274-16828-1-git-send-email-alex.velenko@arm.com |
|---|---|
| State | New |
| Headers | show |
On Wed, 20 May 2015, Alex Velenko wrote: > Hi, > > This patch prevents arm_thumb1_ok XPASS in sibcall-3.c and sibcall-4.c > testcases. Sibcalls are not ok for Thumb1 and testcases need to be fixed. arm_thumb1_ok means "this is an ARM target where -mthumb causes Thumb-1 to be used". It only ever makes sense to use it in tests that use an explicit -mthumb, which these tests don't. If you want to check "is this test being built for Thumb-1 by the multilib options", use arm_thumb1.
On Wed, May 20, 2015 at 9:11 PM, Joseph Myers <joseph@codesourcery.com> wrote: > On Wed, 20 May 2015, Alex Velenko wrote: > >> Hi, >> >> This patch prevents arm_thumb1_ok XPASS in sibcall-3.c and sibcall-4.c >> testcases. Sibcalls are not ok for Thumb1 and testcases need to be fixed. > > arm_thumb1_ok means "this is an ARM target where -mthumb causes Thumb-1 to > be used". It only ever makes sense to use it in tests that use an > explicit -mthumb, which these tests don't. > > If you want to check "is this test being built for Thumb-1 by the multilib > options", use arm_thumb1. > Alex, so while you are here - why don't you improve the documentation in sourcebuild.texi by 1. documenting arm_thumb1 2. distinguishing that from arm_thumb1_ok which just says `ARM target generates Thumb-1 code for @code{-mthumb}.' and that is just meaningless. regards Ramana > -- > Joseph S. Myers > joseph@codesourcery.com
diff --git a/gcc/testsuite/gcc.dg/sibcall-3.c b/gcc/testsuite/gcc.dg/sibcall-3.c index eafe8dd..37f44a1 100644 --- a/gcc/testsuite/gcc.dg/sibcall-3.c +++ b/gcc/testsuite/gcc.dg/sibcall-3.c @@ -8,6 +8,7 @@ /* { dg-do run { xfail { { cris-*-* crisv32-*-* h8300-*-* hppa*64*-*-* m32r-*-* mcore-*-* mn10300-*-* msp430*-*-* nds32*-*-* xstormy16-*-* v850*-*-* vax-*-* xtensa*-*-* } || { arm*-*-* && { ! arm32 } } } } } */ /* -mlongcall disables sibcall patterns. */ /* { dg-skip-if "" { powerpc*-*-* } { "-mlongcall" } { "" } } */ +/* { dg-skip-if "" { arm*-*-* && arm_thumb1_ok } } */ /* { dg-options "-O2 -foptimize-sibling-calls" } */ /* The option -foptimize-sibling-calls is the default, but serves as diff --git a/gcc/testsuite/gcc.dg/sibcall-4.c b/gcc/testsuite/gcc.dg/sibcall-4.c index 1e039c6..9554a95 100644 --- a/gcc/testsuite/gcc.dg/sibcall-4.c +++ b/gcc/testsuite/gcc.dg/sibcall-4.c @@ -8,6 +8,7 @@ /* { dg-do run { xfail { { cris-*-* crisv32-*-* h8300-*-* hppa*64*-*-* m32r-*-* mcore-*-* mn10300-*-* msp430*-*-* nds32*-*-* xstormy16-*-* v850*-*-* vax-*-* xtensa*-*-* } || { arm*-*-* && { ! arm32 } } } } } */ /* -mlongcall disables sibcall patterns. */ /* { dg-skip-if "" { powerpc*-*-* } { "-mlongcall" } { "" } } */ +/* { dg-skip-if "" { arm*-*-* && arm_thumb1_ok } } */ /* { dg-options "-O2 -foptimize-sibling-calls" } */ /* The option -foptimize-sibling-calls is the default, but serves as
Hi, This patch prevents arm_thumb1_ok XPASS in sibcall-3.c and sibcall-4.c testcases. Sibcalls are not ok for Thumb1 and testcases need to be fixed. Is patch ok? gcc/testsuite 2015-05-20 Alex Velenko <Alex.Velenko@arm.com> * gcc.dg/sibcall-3.c (dg-skip-if): Skip if arm_thumb1_ok. * gcc.dg/sibcall-4.c (dg-skip-if): Likewise. --- gcc/testsuite/gcc.dg/sibcall-3.c | 1 + gcc/testsuite/gcc.dg/sibcall-4.c | 1 + 2 files changed, 2 insertions(+)