| Message ID | 1432136124-24572-2-git-send-email-quintela@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 05/20/2015 09:35 AM, Juan Quintela wrote: > We assign the MIGRATION_STATUS_SETUP status in two places. Just in > sucession. Just remove the second one. s/sucession/succession/ Where's the second place? Not in migrate_fd_connect... okay, migrate_init() does the same thing, and I guess you're arguing that it was always called either just before or just after migrate_fd_connect can be called. But mentioning it in the commit message would help. > > Signed-off-by: Juan Quintela <quintela@redhat.com> > --- > migration/migration.c | 3 --- > 1 file changed, 3 deletions(-) > Reviewed-by: Eric Blake <eblake@redhat.com>
On 05/20/2015 11:58 AM, Eric Blake wrote: > On 05/20/2015 09:35 AM, Juan Quintela wrote: >> We assign the MIGRATION_STATUS_SETUP status in two places. Just >> in sucession. Just remove the second one. > > s/sucession/succession/ > Also s/assignement/assignment/ in the subject. > Where's the second place? Not in migrate_fd_connect... > > okay, migrate_init() does the same thing, and I guess you're > arguing that it was always called either just before or just after > migrate_fd_connect can be called. But mentioning it in the commit > message would help. > >> >> Signed-off-by: Juan Quintela <quintela@redhat.com> --- >> migration/migration.c | 3 --- 1 file changed, 3 deletions(-) >> > > Reviewed-by: Eric Blake <eblake@redhat.com> >
John Snow <jsnow@redhat.com> wrote: > On 05/20/2015 11:58 AM, Eric Blake wrote: >> On 05/20/2015 09:35 AM, Juan Quintela wrote: >>> We assign the MIGRATION_STATUS_SETUP status in two places. Just >>> in sucession. Just remove the second one. >> >> s/sucession/succession/ >> > > Also s/assignement/assignment/ in the subject. > >> Where's the second place? Not in migrate_fd_connect... >> >> okay, migrate_init() does the same thing, and I guess you're >> arguing that it was always called either just before or just after >> migrate_fd_connect can be called. But mentioning it in the commit >> message would help. >> >>> >>> Signed-off-by: Juan Quintela <quintela@redhat.com> --- >>> migration/migration.c | 3 --- 1 file changed, 3 deletions(-) >>> >> >> Reviewed-by: Eric Blake <eblake@redhat.com> >> Thanks to both of you. Later, Juan.
diff --git a/migration/migration.c b/migration/migration.c index 1035689..2925587 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -849,9 +849,6 @@ static void *migration_thread(void *opaque) void migrate_fd_connect(MigrationState *s) { - s->state = MIGRATION_STATUS_SETUP; - trace_migrate_set_state(MIGRATION_STATUS_SETUP); - /* This is a best 1st approximation. ns to ms */ s->expected_downtime = max_downtime/1000000; s->cleanup_bh = qemu_bh_new(migrate_fd_cleanup, s);
We assign the MIGRATION_STATUS_SETUP status in two places. Just in sucession. Just remove the second one. Signed-off-by: Juan Quintela <quintela@redhat.com> --- migration/migration.c | 3 --- 1 file changed, 3 deletions(-)