| Message ID | 1432017698-23725-2-git-send-email-21cnbao@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi Barry, On 05/19/2015 01:41 AM, Barry Song wrote: > From: Wei Chen <wei.chen@csr.com> > > The Hardware Spinlock device on atlas7 provides hardware assistance > for synchronization between the multiple processors in the system > (dual Cortex-A7, CAN bus Cortex-M3 and audio DSP). > This patch adds the DT bindings information for this hwspinlock > module. > > Cc: Suman Anna <s-anna@ti.com> > Cc: Bjorn Andersson <bjorn@kryo.se> > Signed-off-by: Wei Chen <wei.chen@csr.com> > Signed-off-by: Barry Song <Baohua.Song@csr.com> > --- > .../devicetree/bindings/hwlock/sirf,hwspinlock.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt > > diff --git a/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt > new file mode 100644 > index 0000000..cc6d351 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt > @@ -0,0 +1,25 @@ > +SIRF Hardware spinlock device Binding > +----------------------------------------------- > + > +Required properties : > +- compatible : shall contain only one of the following: > + "sirf,hwspinlock" > + > +- reg : the register address of hwspinlock Also suggest to document the value to be used for #hwlock-cells, the generic hwlock binding does not mention that. > + > +Please look at the generic hwlock binding for usage information for consumers, > +"Documentation/devicetree/bindings/hwlock/hwlock.txt" > + regards Suman -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-05-23 6:44 GMT+08:00 Suman Anna <s-anna@ti.com>: > Hi Barry, > > On 05/19/2015 01:41 AM, Barry Song wrote: >> From: Wei Chen <wei.chen@csr.com> >> >> The Hardware Spinlock device on atlas7 provides hardware assistance >> for synchronization between the multiple processors in the system >> (dual Cortex-A7, CAN bus Cortex-M3 and audio DSP). >> This patch adds the DT bindings information for this hwspinlock >> module. >> >> Cc: Suman Anna <s-anna@ti.com> >> Cc: Bjorn Andersson <bjorn@kryo.se> >> Signed-off-by: Wei Chen <wei.chen@csr.com> >> Signed-off-by: Barry Song <Baohua.Song@csr.com> >> --- >> .../devicetree/bindings/hwlock/sirf,hwspinlock.txt | 25 ++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt >> >> diff --git a/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt >> new file mode 100644 >> index 0000000..cc6d351 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt >> @@ -0,0 +1,25 @@ >> +SIRF Hardware spinlock device Binding >> +----------------------------------------------- >> + >> +Required properties : >> +- compatible : shall contain only one of the following: >> + "sirf,hwspinlock" >> + >> +- reg : the register address of hwspinlock > > Also suggest to document the value to be used for #hwlock-cells, the > generic hwlock binding does not mention that. do you think whether we can put one line like? #hwlock-cells : <1>, as required by generic hwspinlock binding. > >> + >> +Please look at the generic hwlock binding for usage information for consumers, >> +"Documentation/devicetree/bindings/hwlock/hwlock.txt" >> + > > regards > Suman > -barry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/25/2015 12:33 AM, Barry Song wrote: > 2015-05-23 6:44 GMT+08:00 Suman Anna <s-anna@ti.com>: >> Hi Barry, >> >> On 05/19/2015 01:41 AM, Barry Song wrote: >>> From: Wei Chen <wei.chen@csr.com> >>> >>> The Hardware Spinlock device on atlas7 provides hardware assistance >>> for synchronization between the multiple processors in the system >>> (dual Cortex-A7, CAN bus Cortex-M3 and audio DSP). >>> This patch adds the DT bindings information for this hwspinlock >>> module. >>> >>> Cc: Suman Anna <s-anna@ti.com> >>> Cc: Bjorn Andersson <bjorn@kryo.se> >>> Signed-off-by: Wei Chen <wei.chen@csr.com> >>> Signed-off-by: Barry Song <Baohua.Song@csr.com> >>> --- >>> .../devicetree/bindings/hwlock/sirf,hwspinlock.txt | 25 ++++++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt >>> >>> diff --git a/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt >>> new file mode 100644 >>> index 0000000..cc6d351 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt >>> @@ -0,0 +1,25 @@ >>> +SIRF Hardware spinlock device Binding >>> +----------------------------------------------- >>> + >>> +Required properties : >>> +- compatible : shall contain only one of the following: >>> + "sirf,hwspinlock" >>> + >>> +- reg : the register address of hwspinlock >> >> Also suggest to document the value to be used for #hwlock-cells, the >> generic hwlock binding does not mention that. > > do you think whether we can put one line like? > > #hwlock-cells : <1>, as required by generic hwspinlock binding. The generic hwspinlock binding does not require a specific value, that is something determined by the individual platform implementation. So, something like "#hwlock-cells: Should be 1" is fine. regards Suman >> >>> + >>> +Please look at the generic hwlock binding for usage information for consumers, >>> +"Documentation/devicetree/bindings/hwlock/hwlock.txt" >>> + >> >> regards >> Suman >> > > -barry > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt new file mode 100644 index 0000000..cc6d351 --- /dev/null +++ b/Documentation/devicetree/bindings/hwlock/sirf,hwspinlock.txt @@ -0,0 +1,25 @@ +SIRF Hardware spinlock device Binding +----------------------------------------------- + +Required properties : +- compatible : shall contain only one of the following: + "sirf,hwspinlock" + +- reg : the register address of hwspinlock + +Please look at the generic hwlock binding for usage information for consumers, +"Documentation/devicetree/bindings/hwlock/hwlock.txt" + +Example of hwlock provider: + hwlock { + compatible = "sirf,hwspinlock"; + reg = <0x13240000 0x00010000>; + #hwlock-cells = <1>; + }; + +Example of hwlock users: + node { + ... + hwlocks = <&hwlock 2>; + ... + };