diff mbox

move check-gcc parallelize value into C front end

Message ID CABXYE2WxkD8K0qqy0XPN12nmC8piqu0OD+QuWmL_6GK2AVTBZw@mail.gmail.com
State New
Headers show

Commit Message

Jim Wilson May 18, 2015, 3:42 a.m. UTC 
Every check_$lang_parallelize setting is in the language specific
Make-lang.in file except for the C front-end check_gcc_parallelize
setting which is in the toplevel Makefile.in file.  This seems to be
an oversight, as it was only 3 years ago that the c/ subdir was
created, and the check_gcc_parallelize variable looks like it might be
gcc generic, but it is actually C front end specific as it only affect
check-gcc which is a C front end target.  This patch moves the
variable into the C front end where it belongs.  This also
consolidates the change_$lang_parallelize docs, which are currently
spread across two places.  It also needs to fix two places that
directly refer to the check_gcc_parallelize setting in Makefile.in,
and change them to references to the generic docs.

Also, while looking at this, I noticed that there is no
check_gnat_parallelize set, and check-gnat seems to be the only
testsuite target that hasn't already been parallelized.  This also
looks like an oversight, but I haven't tested a patch for that yet.

Jim

Comments

Jeff Law May 19, 2015, 6:40 a.m. UTC | #1 
On 05/17/2015 09:42 PM, Jim Wilson wrote:
> Every check_$lang_parallelize setting is in the language specific
> Make-lang.in file except for the C front-end check_gcc_parallelize
> setting which is in the toplevel Makefile.in file.  This seems to be
> an oversight, as it was only 3 years ago that the c/ subdir was
> created, and the check_gcc_parallelize variable looks like it might be
> gcc generic, but it is actually C front end specific as it only affect
> check-gcc which is a C front end target.  This patch moves the
> variable into the C front end where it belongs.  This also
> consolidates the change_$lang_parallelize docs, which are currently
> spread across two places.  It also needs to fix two places that
> directly refer to the check_gcc_parallelize setting in Makefile.in,
> and change them to references to the generic docs.
>
> Also, while looking at this, I noticed that there is no
> check_gnat_parallelize set, and check-gnat seems to be the only
> testsuite target that hasn't already been parallelized.  This also
> looks like an oversight, but I haven't tested a patch for that yet.
>
> Jim
>
>
> check-parallel.patch
>
>
> gcc/
> 2015-05-17  Jim Wilson<jim.wilson@linaro.org>
>
> 	* Makefile.in (check_gcc_parallelize): Delete.
> 	(lang_checks_parallelized): Update comment.
>
> gcc/c
> 2015-05-17  Jim Wilson  <wilson@lothlorien>
>
> 	* Make-lang.in (check_gcc_pallelize): Define.
>
> gcc/cp
> 2015-05-17  Jim Wilson  <wilson@lothlorien>
>
> 	* Make-lang.in (check_g++_parallelize): Update comment.
>
> gcc/fortran
> 2015-05-17  Jim Wilson  <wilson@lothlorien>
>
> 	* Make-lang.in (check_gfortran_parallelize): Update comment.
OK.

jeff
diff mbox

Patch

gcc/
2015-05-17  Jim Wilson  <jim.wilson@linaro.org>

	* Makefile.in (check_gcc_parallelize): Delete.
	(lang_checks_parallelized): Update comment.

gcc/c
2015-05-17  Jim Wilson  <wilson@lothlorien>

	* Make-lang.in (check_gcc_pallelize): Define.

gcc/cp
2015-05-17  Jim Wilson  <wilson@lothlorien>

	* Make-lang.in (check_g++_parallelize): Update comment.

gcc/fortran
2015-05-17  Jim Wilson  <wilson@lothlorien>

	* Make-lang.in (check_gfortran_parallelize): Update comment.

Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in	(revision 223208)
+++ gcc/Makefile.in	(working copy)
@@ -528,10 +528,6 @@ 
 xm_defines=@xm_defines@
 lang_checks=
 lang_checks_parallelized=
-# Upper limit to which it is useful to parallelize this lang target.
-# It doesn't make sense to try e.g. 128 goals for small testsuites
-# like objc or go.
-check_gcc_parallelize=10000
 lang_opt_files=@lang_opt_files@ $(srcdir)/c-family/c.opt $(srcdir)/common.opt
 lang_specs_files=@lang_specs_files@
 lang_tree_files=@lang_tree_files@
@@ -3743,7 +3739,9 @@ 
 #
 # To parallelize some language check, add the corresponding check-$lang
 # to lang_checks_parallelized variable and define check_$lang_parallelize
-# variable (see above check_gcc_parallelize description).
+# variable.  This is the upper limit to which it is useful to parallelize the
+# check-$lang target.  It doesn't make sense to try e.g. 128 goals for small
+# testsuites like objc or go.
 $(lang_checks_parallelized): check-% : site.exp
 	-rm -rf $(TESTSUITEDIR)/$*-parallel
 	@if [ "$(filter -j, $(MFLAGS))" = "-j" ]; then \
Index: gcc/c/Make-lang.in
===================================================================
--- gcc/c/Make-lang.in	(revision 223208)
+++ gcc/c/Make-lang.in	(working copy)
@@ -95,6 +95,8 @@ 
 # List of targets that can use the generic check- rule and its // variant.
 lang_checks += check-gcc
 lang_checks_parallelized += check-gcc
+# For description see the check_$lang_parallelize comment in gcc/Makefile.in.
+check_gcc_parallelize=10000
 
 # 'make check' in gcc/ looks for check-c.  Redirect it to check-gcc.
 check-c : check-gcc
Index: gcc/cp/Make-lang.in
===================================================================
--- gcc/cp/Make-lang.in	(revision 223208)
+++ gcc/cp/Make-lang.in	(working copy)
@@ -155,7 +155,7 @@ 
 # List of targets that can use the generic check- rule and its // variant.
 lang_checks += check-g++
 lang_checks_parallelized += check-g++
-# For description see comment above check_gcc_parallelize in gcc/Makefile.in.
+# For description see the check_$lang_parallelize comment in gcc/Makefile.in.
 check_g++_parallelize = 10000
 #
 # Install hooks:
Index: gcc/fortran/Make-lang.in
===================================================================
--- gcc/fortran/Make-lang.in	(revision 223208)
+++ gcc/fortran/Make-lang.in	(working copy)
@@ -167,7 +167,7 @@ 
 check-fortran-subtargets : check-gfortran-subtargets
 lang_checks += check-gfortran
 lang_checks_parallelized += check-gfortran
-# For description see comment above check_gcc_parallelize in gcc/Makefile.in.
+# For description see the check_$lang_parallelize comment in gcc/Makefile.in.
 check_gfortran_parallelize = 10000
 
 # GFORTRAN documentation.