From patchwork Wed Mar 10 18:49:12 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: remove redundant check for file's private_data Date: Wed, 10 Mar 2010 08:49:12 -0000 From: Shirish Pargaonkar X-Patchwork-Id: 47277 Message-Id: <4a4634331003101049n242cf6e4kd992101ff239a265@mail.gmail.com> To: linux-cifs-client@lists.samba.org, Steve French This check is redundant, whether private_data is NULL gets verified in initiate_cifs_search already. Signed-off-by: Shirish Pargaonkar shirishpargaonkar@gmail.com >From c1945aa4698725f8f69c3e402fee7062468075c3 Mon Sep 17 00:00:00 2001 From: Shirish Pargaonkar Date: Wed, 10 Mar 2010 12:24:18 -0600 Subject: [PATCH] remove redundant check for cifs file data --- fs/cifs/readdir.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) if (cifsFile->srch_inf.emptyDir) { diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index c343b14..e8a7794 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c @@ -812,11 +812,7 @@ int cifs_readdir(struct file *file, void *direntry, filldir_t filldir) return rc; } } - if (file->private_data == NULL) { - rc = -EINVAL; - FreeXid(xid); - return rc; - } + cifsFile = file->private_data; if (cifsFile->srch_inf.endOfSearch) {