| Message ID | 1431668830-22734-1-git-send-email-cyrilbur@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Cyril, > These two configs should be identical with the exception of big or > little endian > > The big endian version has XMON_DEFAULT turned on while the little > endian has XMON_DEFAULT not set. Enable XMON_DEFAULT for little > endian. I disabled it on the LE defconfig on purpose. In most cases we want to get the kernel back around and running again. I got sick of building a mainline kernel for a non development box and coming back to it stuck in xmon. Should we disable it by default and require developers who want xmon to set the config option, or use the xmon=on boot? Anton
On 5/24/15, Anton Blanchard <anton@samba.org> wrote: > Hi Cyril, > >> These two configs should be identical with the exception of big or >> little endian >> >> The big endian version has XMON_DEFAULT turned on while the little >> endian has XMON_DEFAULT not set. Enable XMON_DEFAULT for little >> endian. > > I disabled it on the LE defconfig on purpose. In most cases we want to > get the kernel back around and running again. I got sick of building a > mainline kernel for a non development box and coming back to it stuck in > xmon. > > Should we disable it by default and require developers who want xmon to > set the config option, or use the xmon=on boot? I think that it's a good idea to keep it disabled by default > > Anton > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
On Sun, 2015-05-24 at 12:19 +0300, Denis Kirjanov wrote: > On 5/24/15, Anton Blanchard <anton@samba.org> wrote: > > Hi Cyril, > > > >> These two configs should be identical with the exception of big or > >> little endian > >> > >> The big endian version has XMON_DEFAULT turned on while the little > >> endian has XMON_DEFAULT not set. Enable XMON_DEFAULT for little > >> endian. > > > > I disabled it on the LE defconfig on purpose. In most cases we want to > > get the kernel back around and running again. I got sick of building a > > mainline kernel for a non development box and coming back to it stuck in > > xmon. > > > > Should we disable it by default and require developers who want xmon to > > set the config option, or use the xmon=on boot? > > I think that it's a good idea to keep it disabled by default Sure, that behaviour makes sense since and the goal here is to have them be the same, I'll resent the patch to go the other way and turn XMON_DEFAULT off in big endian. Thanks, Cyril > > > > Anton > > _______________________________________________ > > Linuxppc-dev mailing list > > Linuxppc-dev@lists.ozlabs.org > > https://lists.ozlabs.org/listinfo/linuxppc-dev
diff --git a/arch/powerpc/configs/pseries_le_defconfig b/arch/powerpc/configs/pseries_le_defconfig index 09bc96e..2497c7d 100644 --- a/arch/powerpc/configs/pseries_le_defconfig +++ b/arch/powerpc/configs/pseries_le_defconfig @@ -298,6 +298,7 @@ CONFIG_CODE_PATCHING_SELFTEST=y CONFIG_FTR_FIXUP_SELFTEST=y CONFIG_MSI_BITMAP_SELFTEST=y CONFIG_XMON=y +CONFIG_XMON_DEFAULT=y CONFIG_CRYPTO_TEST=m CONFIG_CRYPTO_PCBC=m CONFIG_CRYPTO_HMAC=y
These two configs should be identical with the exception of big or little endian The big endian version has XMON_DEFAULT turned on while the little endian has XMON_DEFAULT not set. Enable XMON_DEFAULT for little endian. Signed-off-by: Cyril Bur <cyrilbur@gmail.com> --- arch/powerpc/configs/pseries_le_defconfig | 1 + 1 file changed, 1 insertion(+)