diff mbox

[net-next] be2net: be_hwmon_show_temp() can be static

Message ID 20150514190234.GA103883@snb
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

kbuild test robot May 14, 2015, 7:02 p.m. UTC
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 be_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller May 14, 2015, 9:39 p.m. UTC | #1
From: kbuild test robot <fengguang.wu@intel.com>
Date: Fri, 15 May 2015 03:02:35 +0800

> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  be_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> index dc7c0fd..76d491f 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -5612,7 +5612,7 @@ static void be_remove(struct pci_dev *pdev)
>  	free_netdev(adapter->netdev);
>  }
>  
> -ssize_t be_hwmon_show_temp(struct device *dev,
> +static ssize_t be_hwmon_show_temp(struct device *dev,
>  			   struct device_attribute *dev_attr,
>  			   char *buf)

If you adjust the column of the openning parenthesis of the
function, you have to reindent the subsequent lines so that they
start precisely at the very next column.

You must use the appropriate number of TAB and SPACE characters
necessary to do so.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
kbuild test robot May 15, 2015, 5:19 a.m. UTC | #2
On Thu, May 14, 2015 at 05:39:46PM -0400, David Miller wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
> Date: Fri, 15 May 2015 03:02:35 +0800
> 
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >  be_main.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> > index dc7c0fd..76d491f 100644
> > --- a/drivers/net/ethernet/emulex/benet/be_main.c
> > +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> > @@ -5612,7 +5612,7 @@ static void be_remove(struct pci_dev *pdev)
> >  	free_netdev(adapter->netdev);
> >  }
> >  
> > -ssize_t be_hwmon_show_temp(struct device *dev,
> > +static ssize_t be_hwmon_show_temp(struct device *dev,
> >  			   struct device_attribute *dev_attr,
> >  			   char *buf)
> 
> If you adjust the column of the openning parenthesis of the
> function, you have to reindent the subsequent lines so that they
> start precisely at the very next column.
> 
> You must use the appropriate number of TAB and SPACE characters
> necessary to do so.

OK. We'll improve the script to adjust indent accordingly.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index dc7c0fd..76d491f 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -5612,7 +5612,7 @@  static void be_remove(struct pci_dev *pdev)
 	free_netdev(adapter->netdev);
 }
 
-ssize_t be_hwmon_show_temp(struct device *dev,
+static ssize_t be_hwmon_show_temp(struct device *dev,
 			   struct device_attribute *dev_attr,
 			   char *buf)
 {