| Message ID | 1431607240-14549-1-git-send-email-tomeu.vizoso@collabora.com |
|---|---|
| State | New |
| Headers | show |
2015-05-14 21:40 GMT+09:00 Tomeu Vizoso <tomeu.vizoso@collabora.com>: > Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by > adding support for PMU regmap") the syscon property is required in > samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated > yet. > > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> > Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Krzysztof Kozłowski <k.kozlowski@samsung.com> > > -- Triple-dash please, because this won't be cut by "git am". Everything else looks fine, thank you. Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
On 05/15/15 22:22, Krzysztof Kozlowski wrote: > 2015-05-14 21:40 GMT+09:00 Tomeu Vizoso <tomeu.vizoso@collabora.com>: >> Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by >> adding support for PMU regmap") the syscon property is required in >> samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated >> yet. >> >> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> >> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> >> Cc: Krzysztof Kozłowski <k.kozlowski@samsung.com> >> >> -- > > Triple-dash please, because this won't be cut by "git am". > > Everything else looks fine, thank you. > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Applied, thanks for you guys' effort. - Kukjin
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 4531753..78bcbc0 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -541,7 +541,7 @@ mipi_phy: video-phy@10040714 { compatible = "samsung,s5pv210-mipi-video-phy"; - reg = <0x10040714 12>; + syscon = <&pmu_system_controller>; #phy-cells = <1>; };
Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by adding support for PMU regmap") the syscon property is required in samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated yet. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Krzysztof Kozłowski <k.kozlowski@samsung.com> -- v2: * Remove reg property as suggested by Javier * Added his Reviewed-by --- arch/arm/boot/dts/exynos5420.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)