diff mbox

Fix linknamespace test handling of architecture-specific st_other [committed]

Message ID alpine.DEB.2.10.1505121710140.30680@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers May 12, 2015, 5:10 p.m. UTC 
For mips16, some of the linknamespace tests were failing because
[MIPS16] annotations in readelf output were wrongly interpreted as
falling in the symbol index field, meaning symbol index values were
wrongly interpreted as symbol names and such names as 1 and 2 then
resulted in namespace test failures.

This patch fixes this by removing the annotations for such
architecture-specific st_other bits before splitting the readelf
output into fields.  Tested for x86_64 and mips16.  Committed.

2015-05-12  Joseph Myers  <joseph@codesourcery.com>

	* conform/linknamespace.pl (list_syms): Remove \[.*?\] before
	splitting into fields.
diff mbox

Patch

diff --git a/conform/linknamespace.pl b/conform/linknamespace.pl
index b534746..8ea437d 100644
--- a/conform/linknamespace.pl
+++ b/conform/linknamespace.pl
@@ -68,6 +68,9 @@  sub list_syms {
       next;
     }
     s/^\s*//;
+    # Architecture-specific st_other bits appear inside [] and disrupt
+    # the format of readelf output.
+    s/\[.*?\]//;
     my (@fields) = split (/\s+/, $_);
     if (@fields < 8) {
       next;