Patchwork Remove slash in QlogicPTI irq name

login
register
mail settings
Submitter Meelis Roos
Date March 8, 2010, 6:23 p.m.
Message ID <alpine.SOC.1.00.1003081809380.26387@math.ut.ee>
Download mbox | patch
Permalink /patch/47124/
State Accepted
Delegated to: David Miller
Headers show

Comments

Meelis Roos - March 8, 2010, 6:23 p.m.
qlogicpti driver registers its irq with a name containing slash.
This results in 

[   71.049735] WARNING: at fs/proc/generic.c:316 __xlate_proc_name+0xa8/0xb8()
[   71.132815] name 'Qlogic/PTI'

because proc_mkdir with the name of the irq fails. Fix it by just 
removing the slash from irq name. Discovered and tested on real hardware 
(Sun Ultra 1).

Signed-off-by: Meelis Roos <mroos@linux.ee>
David Miller - March 8, 2010, 6:53 p.m.
From: Meelis Roos <mroos@linux.ee>
Date: Mon, 8 Mar 2010 20:23:20 +0200 (EET)

> qlogicpti driver registers its irq with a name containing slash.
> This results in 
> 
> [   71.049735] WARNING: at fs/proc/generic.c:316 __xlate_proc_name+0xa8/0xb8()
> [   71.132815] name 'Qlogic/PTI'
> 
> because proc_mkdir with the name of the irq fails. Fix it by just 
> removing the slash from irq name. Discovered and tested on real hardware 
> (Sun Ultra 1).
> 
> Signed-off-by: Meelis Roos <mroos@linux.ee>

Applied, thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index fa34b92..1b82170 100644
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -738,7 +738,7 @@  static int __devinit qpti_register_irq(struct qlogicpti *qpti)
 	 * sanely maintain.
 	 */
 	if (request_irq(qpti->irq, qpti_intr,
-			IRQF_SHARED, "Qlogic/PTI", qpti))
+			IRQF_SHARED, "QlogicPTI", qpti))
 		goto fail;
 
 	printk("qlogicpti%d: IRQ %d ", qpti->qpti_id, qpti->irq);