From patchwork Mon Mar 8 12:07:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: sdl: improve error message on fatal error Date: Mon, 08 Mar 2010 02:07:14 -0000 From: =?utf-8?b?QmrDuHJuIE1vcmsgPGJqb3JuQG1vcmsubm8+?= X-Patchwork-Id: 47112 Message-Id: <1268050034-7376-1-git-send-email-bjorn@mork.no> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Bj=C3=B8rn=20Mork?= The SDL_SetVideoMode() error condition is easily triggered by a user by simply configure a guest with a host unsupported display resolution and attempting to enable fullscreen. Since the error is fatal, adding a bit of debugging help can't harm. Sample output with this change: (qemu) Could not open SDL display (1280x1024x32): No video mode large enough for 1280x1024 The width x height might seem redundant as SDL also provides it in SDL_GetError(), but I believe there are situations where it is useful. I.e. if there is some other SDL error. Anyway, redundant information in fatal error messages has never harmed a single gerbil. Signed-off-by: Bjørn Mork --- sdl.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/sdl.c b/sdl.c index f26035c..34061c0 100644 --- a/sdl.c +++ b/sdl.c @@ -112,7 +112,8 @@ static void do_sdl_resize(int new_width, int new_height, int bpp) height = new_height; real_screen = SDL_SetVideoMode(width, height, bpp, flags); if (!real_screen) { - fprintf(stderr, "Could not open SDL display\n"); + fprintf(stderr, "Could not open SDL display (%dx%dx%d): %s\n", width, + height, bpp, SDL_GetError()); exit(1); } }