diff mbox

[U-Boot,4/4] sunxi: Change usb-kbd interrupt polling to use an usb interrupt qeueue

Message ID 1431371289-17175-5-git-send-email-hdegoede@redhat.com
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Hans de Goede May 11, 2015, 7:08 p.m. UTC
Now that the ohci code supports usb interrupt qeueues we can switch (back)
to using an usb interrupt qeueue for usb-kbd interrupt polling. This
greatly reduces u-boot's latency when dealing with usb keyboards.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 include/configs/sunxi-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ian Campbell May 11, 2015, 7:17 p.m. UTC | #1
On Mon, 2015-05-11 at 21:08 +0200, Hans de Goede wrote:
> Now that the ohci code supports usb interrupt qeueues we can switch (back)
> to using an usb interrupt qeueue for usb-kbd interrupt polling. This

"queues" and "queue".

> greatly reduces u-boot's latency when dealing with usb keyboards.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

> ---
>  include/configs/sunxi-common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
> index 222e739..2d6b815 100644
> --- a/include/configs/sunxi-common.h
> +++ b/include/configs/sunxi-common.h
> @@ -317,7 +317,7 @@ extern int soft_i2c_gpio_scl;
>  #define CONFIG_CONSOLE_MUX
>  #define CONFIG_PREBOOT
>  #define CONFIG_SYS_STDIO_DEREGISTER
> -#define CONFIG_SYS_USB_EVENT_POLL
> +#define CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE
>  #endif
>  
>  #if !defined CONFIG_ENV_IS_IN_MMC && \
Marek Vasut May 11, 2015, 7:19 p.m. UTC | #2
On Monday, May 11, 2015 at 09:08:09 PM, Hans de Goede wrote:
> Now that the ohci code supports usb interrupt qeueues we can switch (back)

queues ;-)

> to using an usb interrupt qeueue for usb-kbd interrupt polling. This
> greatly reduces u-boot's latency when dealing with usb keyboards.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Reviewed-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
index 222e739..2d6b815 100644
--- a/include/configs/sunxi-common.h
+++ b/include/configs/sunxi-common.h
@@ -317,7 +317,7 @@  extern int soft_i2c_gpio_scl;
 #define CONFIG_CONSOLE_MUX
 #define CONFIG_PREBOOT
 #define CONFIG_SYS_STDIO_DEREGISTER
-#define CONFIG_SYS_USB_EVENT_POLL
+#define CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE
 #endif
 
 #if !defined CONFIG_ENV_IS_IN_MMC && \