Patchwork net: add __must_check to sk_add_backlog

login
register
mail settings
Submitter Zhu Yi
Date March 8, 2010, 2:21 a.m.
Message ID <1268014899-31318-1-git-send-email-yi.zhu@intel.com>
Download mbox | patch
Permalink /patch/47100/
State Accepted
Delegated to: David Miller
Headers show

Comments

Zhu Yi - March 8, 2010, 2:21 a.m.
Add the "__must_check" tag to sk_add_backlog() so that any failure to
check and drop packets will be warned about.

Signed-off-by: Zhu Yi <yi.zhu@intel.com>
---
 include/net/sock.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - March 8, 2010, 6:46 p.m.
From: Zhu Yi <yi.zhu@intel.com>
Date: Mon,  8 Mar 2010 10:21:39 +0800

> Add the "__must_check" tag to sk_add_backlog() so that any failure to
> check and drop packets will be warned about.
> 
> Signed-off-by: Zhu Yi <yi.zhu@intel.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/net/sock.h b/include/net/sock.h
index 170353d..092b055 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -604,7 +604,7 @@  static inline void __sk_add_backlog(struct sock *sk, struct sk_buff *skb)
 }
 
 /* The per-socket spinlock must be held here. */
-static inline int sk_add_backlog(struct sock *sk, struct sk_buff *skb)
+static inline __must_check int sk_add_backlog(struct sock *sk, struct sk_buff *skb)
 {
 	if (sk->sk_backlog.len >= max(sk->sk_backlog.limit, sk->sk_rcvbuf << 1))
 		return -ENOBUFS;