diff mbox

[Utopic,SRU] UBUNTU: SAUCE: (no-up) trace: fix trace_open_exec() invocation

Message ID 1431359031-24803-1-git-send-email-luis.henriques@canonical.com
State New
Headers show

Commit Message

Luis Henriques May 11, 2015, 3:43 p.m. UTC
Commit f9ec64c008e7 ("UBUNTU: SAUCE: (no-up) trace: add trace events for
open(), exec() and uselib() (for v3.7+)") invoques trace_open_exec() with
a wrong argument type: 'struct filename *' instead of 'char *'.

This bug was introduced in Utopic when forward-porting this patch from
Trusty.

Fixes: f9ec64c008e7 ("UBUNTU: SAUCE: (no-up) trace: add trace events for open(), exec() and uselib() (for v3.7+)")
BugLink: https://bugs.launchpad.net/bugs/1453848
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---
 fs/exec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Gardner May 11, 2015, 3:50 p.m. UTC | #1

Chris J Arges May 11, 2015, 3:57 p.m. UTC | #2
On 05/11/2015 10:43 AM, Luis Henriques wrote:
> Commit f9ec64c008e7 ("UBUNTU: SAUCE: (no-up) trace: add trace events for
> open(), exec() and uselib() (for v3.7+)") invoques trace_open_exec() with
> a wrong argument type: 'struct filename *' instead of 'char *'.
> 
> This bug was introduced in Utopic when forward-porting this patch from
> Trusty.
> 
> Fixes: f9ec64c008e7 ("UBUNTU: SAUCE: (no-up) trace: add trace events for open(), exec() and uselib() (for v3.7+)")
> BugLink: https://bugs.launchpad.net/bugs/1453848
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> ---
>  fs/exec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/exec.c b/fs/exec.c
> index 4e65c244e4b4..794d9acbba57 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -777,7 +777,7 @@ static struct file *do_open_exec(struct filename *name)
>  
>  	fsnotify_open(file);
>  
> -	trace_open_exec(name);
> +	trace_open_exec(name->name);
>  
>  	err = deny_write_access(file);
>  	if (err)
>
Brad Figg May 14, 2015, 4:13 p.m. UTC | #3
Applied to Utopic master-next.
diff mbox

Patch

diff --git a/fs/exec.c b/fs/exec.c
index 4e65c244e4b4..794d9acbba57 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -777,7 +777,7 @@  static struct file *do_open_exec(struct filename *name)
 
 	fsnotify_open(file);
 
-	trace_open_exec(name);
+	trace_open_exec(name->name);
 
 	err = deny_write_access(file);
 	if (err)