From patchwork Sun Mar 7 10:48:52 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 47076 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4722BB7067 for ; Sun, 7 Mar 2010 21:56:06 +1100 (EST) Received: from localhost ([127.0.0.1]:56197 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NoE8K-0001Zm-UB for incoming@patchwork.ozlabs.org; Sun, 07 Mar 2010 05:54:52 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NoE3d-0000rg-Ui for qemu-devel@nongnu.org; Sun, 07 Mar 2010 05:50:02 -0500 Received: from [199.232.76.173] (port=33467 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NoE3c-0000rU-KS for qemu-devel@nongnu.org; Sun, 07 Mar 2010 05:50:00 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NoE3b-0003Gr-Fj for qemu-devel@nongnu.org; Sun, 07 Mar 2010 05:50:00 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:40438) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NoE3b-0003Gg-4g for qemu-devel@nongnu.org; Sun, 07 Mar 2010 05:49:59 -0500 Received: from smtp05.web.de (fmsmtp05.dlan.cinetic.de [172.20.4.166]) by fmmailgate03.web.de (Postfix) with ESMTP id 092191429EA4A; Sun, 7 Mar 2010 11:48:55 +0100 (CET) Received: from [92.74.59.117] (helo=[192.168.1.10]) by smtp05.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #314) id 1NoE2X-0003j5-00; Sun, 07 Mar 2010 11:48:53 +0100 Message-ID: <4B938494.1040100@web.de> Date: Sun, 07 Mar 2010 11:48:52 +0100 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Anthony Liguori X-Enigmail-Version: 0.95.7 X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX18doeaCPlvdnNXu9IEMOrzrElyQjcyPI1fx3mSk 8MKDwdblFc4aeRSD7COrtW3pTq/nquLgkhsa+UxaBYXXsZciUK jyf6WHlyk= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 Cc: qemu-devel Subject: [Qemu-devel] [PATCH] Avoid crash on '-usbdevice ' without parameters X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Many usbdevice_init implementors assume params is non-NULL. Signed-off-by: Jan Kiszka --- hw/usb-bus.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 7c82314..89e2ea6 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -275,6 +275,7 @@ USBDevice *usbdevice_create(const char *cmdline) len = sizeof(driver); pstrcpy(driver, len, cmdline); } else { + params = ""; pstrcpy(driver, sizeof(driver), cmdline); }