| Message ID | 1431116920.22756.18.camel@edumazet-glaptop2.roam.corp.google.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
On 05/08/2015 10:28 PM, Eric Dumazet wrote: > From: Eric Dumazet <edumazet@google.com> > > Missing space before dctcp: markers. > > With dctcp, cwnd=2 is pretty common, just display cwnd value even > if cwnd has this value, it makes parsing easier. > > Signed-off-by: Eric Dumazet <edumazet@google.com> Thanks Eric! Acked-by: Daniel Borkmann <daniel@iogearbox.net> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 08 May 2015 13:28:40 -0700 Eric Dumazet <eric.dumazet@gmail.com> wrote: > From: Eric Dumazet <edumazet@google.com> > > Missing space before dctcp: markers. > > With dctcp, cwnd=2 is pretty common, just display cwnd value even > if cwnd has this value, it makes parsing easier. > > Signed-off-by: Eric Dumazet <edumazet@google.com> Applied, thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/misc/ss.c b/misc/ss.c index 46dbb39..18ac105 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -1684,7 +1684,7 @@ static void tcp_stats_print(struct tcpstat *s) if (s->mss) printf(" mss:%d", s->mss); - if (s->cwnd && s->cwnd != 2) + if (s->cwnd) printf(" cwnd:%d", s->cwnd); if (s->ssthresh) printf(" ssthresh:%d", s->ssthresh); @@ -1692,11 +1692,11 @@ static void tcp_stats_print(struct tcpstat *s) if (s->dctcp && s->dctcp->enabled) { struct dctcpstat *dctcp = s->dctcp; - printf("dctcp:(ce_state:%u,alpha:%u,ab_ecn:%u,ab_tot:%u)", + printf(" dctcp:(ce_state:%u,alpha:%u,ab_ecn:%u,ab_tot:%u)", dctcp->ce_state, dctcp->alpha, dctcp->ab_ecn, dctcp->ab_tot); } else if (s->dctcp) { - printf("dctcp:fallback_mode"); + printf(" dctcp:fallback_mode"); } if (s->send_bps)