| Message ID | 1431088998-27721-5-git-send-email-quintela@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 05/08/2015 06:43 AM, Juan Quintela wrote: do you want s/movement/migration/ in the subject? > To make changes easier, with the copy, I maintained almost all include > files. Now I remove the not needed ones on this patch. This complies s/not needed/unnecessary/ s/complies/compiles/ > on linux x64 with all architecutes configured, and cross-compile for s/architecutes/architectures/ s/compile/compiles/ > windows 32 and 64 bits.# s/#$// > > Signed-off-by: Juan Quintela <quintela@redhat.com> > --- > arch_init.c | 23 ----------------------- > migration/ram.c | 18 ++---------------- > 2 files changed, 2 insertions(+), 39 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
Eric Blake <eblake@redhat.com> wrote: > On 05/08/2015 06:43 AM, Juan Quintela wrote: > > do you want s/movement/migration/ in the subject? > >> To make changes easier, with the copy, I maintained almost all include >> files. Now I remove the not needed ones on this patch. This complies > > s/not needed/unnecessary/ > s/complies/compiles/ > >> on linux x64 with all architecutes configured, and cross-compile for > > s/architecutes/architectures/ > s/compile/compiles/ > >> windows 32 and 64 bits.# > > s/#$// > >> >> Signed-off-by: Juan Quintela <quintela@redhat.com> Thanks Included all the changes on the pull request. And redid the 1st patch with the "patience" bit that you suggested. Thanks again, Juan. >> --- >> arch_init.c | 23 ----------------------- >> migration/ram.c | 18 ++---------------- >> 2 files changed, 2 insertions(+), 39 deletions(-) > > Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/arch_init.c b/arch_init.c index 1f34ad7..7c0d73e 100644 --- a/arch_init.c +++ b/arch_init.c @@ -22,38 +22,15 @@ * THE SOFTWARE. */ #include <stdint.h> -#include <stdarg.h> -#include <stdlib.h> -#include <zlib.h> -#ifndef _WIN32 -#include <sys/types.h> -#include <sys/mman.h> -#endif -#include "config.h" -#include "monitor/monitor.h" #include "sysemu/sysemu.h" -#include "qemu/bitops.h" -#include "qemu/bitmap.h" #include "sysemu/arch_init.h" -#include "audio/audio.h" -#include "hw/i386/pc.h" #include "hw/pci/pci.h" #include "hw/audio/audio.h" -#include "sysemu/kvm.h" -#include "migration/migration.h" #include "hw/i386/smbios.h" -#include "exec/address-spaces.h" -#include "hw/audio/pcspk.h" -#include "migration/page_cache.h" #include "qemu/config-file.h" #include "qemu/error-report.h" #include "qmp-commands.h" -#include "trace.h" -#include "exec/cpu-all.h" -#include "exec/ram_addr.h" #include "hw/acpi/acpi.h" -#include "qemu/host-utils.h" -#include "qemu/rcu_queue.h" #ifdef TARGET_SPARC int graphic_width = 1024; diff --git a/migration/ram.c b/migration/ram.c index 61150a5..14b81fc 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -26,31 +26,17 @@ * THE SOFTWARE. */ #include <stdint.h> -#include <stdarg.h> -#include <stdlib.h> #include <zlib.h> -#ifndef _WIN32 -#include <sys/types.h> -#include <sys/mman.h> -#endif -#include "config.h" -#include "monitor/monitor.h" -#include "sysemu/sysemu.h" #include "qemu/bitops.h" #include "qemu/bitmap.h" -#include "hw/i386/pc.h" -#include "hw/pci/pci.h" -#include "hw/audio/audio.h" +#include "qemu/timer.h" +#include "qemu/main-loop.h" #include "migration/migration.h" #include "exec/address-spaces.h" #include "migration/page_cache.h" -#include "qemu/config-file.h" #include "qemu/error-report.h" -#include "qmp-commands.h" #include "trace.h" -#include "exec/cpu-all.h" #include "exec/ram_addr.h" -#include "qemu/host-utils.h" #include "qemu/rcu_queue.h" #ifdef DEBUG_MIGRATION_RAM
To make changes easier, with the copy, I maintained almost all include files. Now I remove the not needed ones on this patch. This complies on linux x64 with all architecutes configured, and cross-compile for windows 32 and 64 bits.# Signed-off-by: Juan Quintela <quintela@redhat.com> --- arch_init.c | 23 ----------------------- migration/ram.c | 18 ++---------------- 2 files changed, 2 insertions(+), 39 deletions(-)