Patchwork use absolute URLs for .gitmodules

login
register
mail settings
Submitter Paolo Bonzini
Date March 5, 2010, 8:08 a.m.
Message ID <1267776484-10816-1-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/47001/
State New
Headers show

Comments

Paolo Bonzini - March 5, 2010, 8:08 a.m.
The relative URLs do not work when cloning a fork of qemu or when
cloning from the Savannah URL.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 .gitmodules |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Aurelien Jarno - March 6, 2010, 10:10 p.m.
On Fri, Mar 05, 2010 at 09:08:04AM +0100, Paolo Bonzini wrote:
> The relative URLs do not work when cloning a fork of qemu or when
> cloning from the Savannah URL.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  .gitmodules |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.gitmodules b/.gitmodules
> index dd4745e..5217ce7 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,6 +1,6 @@
>  [submodule "roms/vgabios"]
>  	path = roms/vgabios
> -	url = ../vgabios.git
> +	url = git://git.qemu.org/vgabios.git/
>  [submodule "roms/seabios"]
>  	path = roms/seabios
> -	url = ../seabios.git
> +	url = git://git.qemu.org/seabios.git/

Is the slash at the end of the URL really wanted?
Paolo Bonzini - March 7, 2010, 10:06 a.m.
On 03/06/2010 11:10 PM, Aurelien Jarno wrote:
> Is the slash at the end of the URL really wanted?

It works either with or without.

Paolo
Anthony Liguori - March 9, 2010, 2:36 p.m.
On 03/05/2010 02:08 AM, Paolo Bonzini wrote:
> The relative URLs do not work when cloning a fork of qemu or when
> cloning from the Savannah URL.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   .gitmodules |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.gitmodules b/.gitmodules
> index dd4745e..5217ce7 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,6 +1,6 @@
>   [submodule "roms/vgabios"]
>   	path = roms/vgabios
> -	url = ../vgabios.git
> +	url = git://git.qemu.org/vgabios.git/
>   [submodule "roms/seabios"]
>   	path = roms/seabios
> -	url = ../seabios.git
> +	url = git://git.qemu.org/seabios.git/
>    

Relative URLs are more friendly for users of proxies.

Regards,

Anthony Liguori

Patch

diff --git a/.gitmodules b/.gitmodules
index dd4745e..5217ce7 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,6 +1,6 @@ 
 [submodule "roms/vgabios"]
 	path = roms/vgabios
-	url = ../vgabios.git
+	url = git://git.qemu.org/vgabios.git/
 [submodule "roms/seabios"]
 	path = roms/seabios
-	url = ../seabios.git
+	url = git://git.qemu.org/seabios.git/