From patchwork Thu Mar 4 21:45:10 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [3/3] tcg: declare internal helpers as const and pure From: Aurelien Jarno X-Patchwork-Id: 46985 Message-Id: <1267739110-26400-4-git-send-email-aurelien@aurel32.net> To: qemu-devel@nongnu.org Cc: Andrzej Zaborowski , Aurelien Jarno Date: Thu, 4 Mar 2010 22:45:10 +0100 TCG internal helpers only access to the values passed in arguments, and do not modify the CPU internal state. Thus they can be declared as const and pure. Signed-off-by: Aurelien Jarno --- tcg/tcg-op.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index c71e1a8..30a7a73 100644 --- a/tcg/tcg-op.h +++ b/tcg/tcg-op.h @@ -364,7 +364,6 @@ static inline void tcg_gen_helperN(void *func, int flags, int sizemask, tcg_temp_free_ptr(fn); } -/* FIXME: Should this be pure? */ static inline void tcg_gen_helper32(void *func, TCGv_i32 ret, TCGv_i32 a, TCGv_i32 b) { @@ -373,11 +372,11 @@ static inline void tcg_gen_helper32(void *func, TCGv_i32 ret, fn = tcg_const_ptr((tcg_target_long)func); args[0] = GET_TCGV_I32(a); args[1] = GET_TCGV_I32(b); - tcg_gen_callN(&tcg_ctx, fn, 0, 0, GET_TCGV_I32(ret), 2, args); + tcg_gen_callN(&tcg_ctx, fn, TCG_CALL_CONST | TCG_CALL_PURE, + 0, GET_TCGV_I32(ret), 2, args); tcg_temp_free_ptr(fn); } -/* FIXME: Should this be pure? */ static inline void tcg_gen_helper64(void *func, TCGv_i64 ret, TCGv_i64 a, TCGv_i64 b) { @@ -386,7 +385,8 @@ static inline void tcg_gen_helper64(void *func, TCGv_i64 ret, fn = tcg_const_ptr((tcg_target_long)func); args[0] = GET_TCGV_I64(a); args[1] = GET_TCGV_I64(b); - tcg_gen_callN(&tcg_ctx, fn, 0, 7, GET_TCGV_I64(ret), 2, args); + tcg_gen_callN(&tcg_ctx, fn, TCG_CALL_CONST | TCG_CALL_PURE, + 7, GET_TCGV_I64(ret), 2, args); tcg_temp_free_ptr(fn); }