From patchwork Thu Mar 4 15:56:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 46956 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A668BB7CFD for ; Fri, 5 Mar 2010 04:26:46 +1100 (EST) Received: from localhost ([127.0.0.1]:56114 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NnEos-0004Lv-6e for incoming@patchwork.ozlabs.org; Thu, 04 Mar 2010 12:26:42 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NnDXc-0005jh-SY for qemu-devel@nongnu.org; Thu, 04 Mar 2010 11:04:48 -0500 Received: from [199.232.76.173] (port=58591 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NnDXc-0005j6-4n for qemu-devel@nongnu.org; Thu, 04 Mar 2010 11:04:48 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NnDXT-0001RK-AH for qemu-devel@nongnu.org; Thu, 04 Mar 2010 11:04:47 -0500 Received: from oxygen.pond.sub.org ([213.239.205.148]:47494) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NnDXQ-0001QD-DW for qemu-devel@nongnu.org; Thu, 04 Mar 2010 11:04:37 -0500 Received: from blackfin.pond.sub.org (pD9E38041.dip.t-dialin.net [217.227.128.65]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 7EEB02DD32B for ; Thu, 4 Mar 2010 17:04:31 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 500) id C963216C; Thu, 4 Mar 2010 16:57:13 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Thu, 4 Mar 2010 16:56:53 +0100 Message-Id: <1267718231-13303-33-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.6.6.1 In-Reply-To: <1267718231-13303-1-git-send-email-armbru@redhat.com> References: <1267718231-13303-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Luiz Capitulino Subject: [Qemu-devel] [PATCH 32/50] qdev: convert setting device properties to QError X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Markus Armbruster --- hw/qdev-properties.c | 6 ++---- hw/qdev.c | 2 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 11f7b76..780a9d8 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -544,13 +544,11 @@ int qdev_prop_parse(DeviceState *dev, const char *name, const char *value) * removed along with it. */ if (!prop || !prop->info->parse) { - fprintf(stderr, "property \"%s.%s\" not found\n", - dev->info->name, name); + qerror_report(QERR_PROPERTY_NOT_FOUND, dev->info->name, name); return -1; } if (prop->info->parse(dev, prop, value) != 0) { - fprintf(stderr, "property \"%s.%s\": failed to parse \"%s\"\n", - dev->info->name, name, value); + qerror_report(QERR_PROPERTY_VALUE_BAD, dev->info->name, name, value); return -1; } return 0; diff --git a/hw/qdev.c b/hw/qdev.c index 1a6f257..1de4ff6 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -146,8 +146,6 @@ static int set_property(const char *name, const char *value, void *opaque) return 0; if (qdev_prop_parse(dev, name, value) == -1) { - error_report("can't set property \"%s\" to \"%s\" for \"%s\"", - name, value, dev->info->name); return -1; } return 0;