Patchwork i2c-cpm: Suppress autoprobing for devices

login
register
mail settings
Submitter Wolfram Sang
Date Oct. 16, 2008, 11:13 a.m.
Message ID <20081016111300.GC3432@pengutronix.de>
Download mbox | patch
Permalink /patch/4691/
State Accepted, archived
Commit 0a346dacee18ff69f6162d9860d723a058f47321
Headers show

Comments

Wolfram Sang - Oct. 16, 2008, 11:13 a.m.
Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also remove
automatic probing for this i2c controller. Might need updates to dts files
using it.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
 drivers/i2c/busses/i2c-cpm.c |    1 -
 1 file changed, 1 deletion(-)
Jochen Friedrich - Oct. 16, 2008, 11:39 a.m.
Wolfram Sang schrieb:
> Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also remove
> automatic probing for this i2c controller. Might need updates to dts files
> using it.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Jochen Friedrich <jochen@scram.de>
Kumar Gala - Oct. 16, 2008, 4:09 p.m.
On Oct 16, 2008, at 6:13 AM, Wolfram Sang wrote:

>
> Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also  
> remove
> automatic probing for this i2c controller. Might need updates to dts  
> files
> using it.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> drivers/i2c/busses/i2c-cpm.c |    1 -
> 1 file changed, 1 deletion(-)

The i2c list should be CC'd.  Jean should pick this up.

- k
David Miller - Oct. 16, 2008, 7:23 p.m.
From: Kumar Gala <galak@kernel.crashing.org>
Date: Thu, 16 Oct 2008 11:09:30 -0500

> 
> On Oct 16, 2008, at 6:13 AM, Wolfram Sang wrote:
> 
> >
> > Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also remove
> > automatic probing for this i2c controller. Might need updates to dts files
> > using it.
> >
> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > ---
> > drivers/i2c/busses/i2c-cpm.c |    1 -
> > 1 file changed, 1 deletion(-)
> 
> The i2c list should be CC'd.  Jean should pick this up.

Don't bother, he'll just argue with you about the fact that class
based probing should be maintained.

He's doing exactly that with me right now.

I think the powerpc folks are doing exactly the right thing by merging
their I2C changes directly to Linus.  Please just continue doing this.

That's what I should have done with my sparc stuff, I'm being punished
now for having sent my changes to "the right place". :-/
Wolfram Sang - Oct. 16, 2008, 8:39 p.m.
On Thu, Oct 16, 2008 at 12:23:25PM -0700, David Miller wrote:

> Don't bother, he'll just argue with you about the fact that class
> based probing should be maintained.
> 
> He's doing exactly that with me right now.

I think the two of you talked at cross purposes. Just observing, I can
follow his point, that you can easily switch probing off in the driver
(like Wolfgang Grandegger's and my patch does), so there is no need to
sacrifice some functionality of a whole algorithm. Just clear the
.class-entry in your driver and there should be peace ;)

All the best,

   Wolfram

Patch

Index: linux-2.6/drivers/i2c/busses/i2c-cpm.c
===================================================================
--- linux-2.6.orig/drivers/i2c/busses/i2c-cpm.c
+++ linux-2.6/drivers/i2c/busses/i2c-cpm.c
@@ -423,7 +423,6 @@  static const struct i2c_adapter cpm_ops 
 	.owner		= THIS_MODULE,
 	.name		= "i2c-cpm",
 	.algo		= &cpm_i2c_algo,
-	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD,
 };
 
 static int __devinit cpm_i2c_setup(struct cpm_i2c *cpm)