Patchwork scsi: update comment on the standards revision

login
register
mail settings
Submitter Christoph Hellwig
Date March 4, 2010, 1:45 p.m.
Message ID <20100304134544.GA3109@lst.de>
Download mbox | patch
Permalink /patch/46909/
State New
Headers show

Comments

Christoph Hellwig - March 4, 2010, 1:45 p.m.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Aurelien Jarno - March 6, 2010, 10:06 p.m.
On Thu, Mar 04, 2010 at 02:45:44PM +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks, applied.

> Index: qemu/hw/scsi-disk.c
> ===================================================================
> --- qemu.orig/hw/scsi-disk.c	2010-03-04 14:39:43.699022260 +0100
> +++ qemu/hw/scsi-disk.c	2010-03-04 14:41:26.768255602 +0100
> @@ -462,8 +462,12 @@ static int scsi_disk_emulate_inquiry(SCS
>      }
>      memcpy(&outbuf[8], "QEMU    ", 8);
>      memcpy(&outbuf[32], s->version ? s->version : QEMU_VERSION, 4);
> -    /* Identify device as SCSI-3 rev 1.
> -       Some later commands are also implemented. */
> +    /*
> +     * We claim conformance to SPC-3, which is required for guests
> +     * to ask for modern features like READ CAPACITY(16) or the
> +     * block characteristics VPD page by default.  Not all of SPC-3
> +     * is actually implemented, but we're good enough.
> +     */
>      outbuf[2] = 5;
>      outbuf[3] = 2; /* Format 2 */
>  
> 
> 
>

Patch

Index: qemu/hw/scsi-disk.c
===================================================================
--- qemu.orig/hw/scsi-disk.c	2010-03-04 14:39:43.699022260 +0100
+++ qemu/hw/scsi-disk.c	2010-03-04 14:41:26.768255602 +0100
@@ -462,8 +462,12 @@  static int scsi_disk_emulate_inquiry(SCS
     }
     memcpy(&outbuf[8], "QEMU    ", 8);
     memcpy(&outbuf[32], s->version ? s->version : QEMU_VERSION, 4);
-    /* Identify device as SCSI-3 rev 1.
-       Some later commands are also implemented. */
+    /*
+     * We claim conformance to SPC-3, which is required for guests
+     * to ask for modern features like READ CAPACITY(16) or the
+     * block characteristics VPD page by default.  Not all of SPC-3
+     * is actually implemented, but we're good enough.
+     */
     outbuf[2] = 5;
     outbuf[3] = 2; /* Format 2 */