diff mbox

uclibc-ng: enable context functions

Message ID 20150506175030.GA2853@waldemar-brodkorb.de
State Superseded
Headers show

Commit Message

Waldemar Brodkorb May 6, 2015, 5:50 p.m. UTC
For mongrel2/libsigsegv we need to enable this in the uClibc-ng config.
Tested with ARM:

file output/target/usr/bin/mongrel2
output/target/usr/bin/mongrel2: ELF 32-bit LSB executable, ARM, version 1 (SYSV), dynamically linked (uses shared libs), stripped

Should fix:
http://autobuild.buildroot.net/results/a144bc6024415a5272c3cbe60ff636d078d0a555/
http://autobuild.buildroot.net/results/00195d89a115a314bf4916af127407f61cd1b418/
http://autobuild.buildroot.net/results/5ee7e83ebcfa43f6ee0a2a8b9f40f1ae84664aca/

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/uclibc/uClibc-ng.config |    1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni May 6, 2015, 7:23 p.m. UTC | #1
Dear Waldemar Brodkorb,

On Wed, 6 May 2015 19:50:30 +0200, Waldemar Brodkorb wrote:
> For mongrel2/libsigsegv we need to enable this in the uClibc-ng config.
> Tested with ARM:
> 
> file output/target/usr/bin/mongrel2
> output/target/usr/bin/mongrel2: ELF 32-bit LSB executable, ARM, version 1 (SYSV), dynamically linked (uses shared libs), stripped
> 
> Should fix:
> http://autobuild.buildroot.net/results/a144bc6024415a5272c3cbe60ff636d078d0a555/
> http://autobuild.buildroot.net/results/00195d89a115a314bf4916af127407f61cd1b418/
> http://autobuild.buildroot.net/results/5ee7e83ebcfa43f6ee0a2a8b9f40f1ae84664aca/
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/uclibc/uClibc-ng.config |    1 +
>  1 file changed, 1 insertion(+)

We don't have this option enabled in uClibc-0.9.33.config. Should I
assume that it's because this option doesn't exist in the 0.9.33.x
uClibc branch?

Also, why don't we have this option enabled in uClibc-snapshot.config?

Thanks,

Thomas
Yann E. MORIN May 6, 2015, 10:10 p.m. UTC | #2
Thomas, All,

On 2015-05-06 21:23 +0200, Thomas Petazzoni spake thusly:
> On Wed, 6 May 2015 19:50:30 +0200, Waldemar Brodkorb wrote:
> > For mongrel2/libsigsegv we need to enable this in the uClibc-ng config.
> > Tested with ARM:
> > 
> > file output/target/usr/bin/mongrel2
> > output/target/usr/bin/mongrel2: ELF 32-bit LSB executable, ARM, version 1 (SYSV), dynamically linked (uses shared libs), stripped
> > 
> > Should fix:
> > http://autobuild.buildroot.net/results/a144bc6024415a5272c3cbe60ff636d078d0a555/
> > http://autobuild.buildroot.net/results/00195d89a115a314bf4916af127407f61cd1b418/
> > http://autobuild.buildroot.net/results/5ee7e83ebcfa43f6ee0a2a8b9f40f1ae84664aca/
> > 
> > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> > ---
> >  package/uclibc/uClibc-ng.config |    1 +
> >  1 file changed, 1 insertion(+)
> 
> We don't have this option enabled in uClibc-0.9.33.config. Should I
> assume that it's because this option doesn't exist in the 0.9.33.x
> uClibc branch?

Yes, context stuff is only on master (added 2013-01-09).

Regards,
Yann E. MORIN.
Waldemar Brodkorb May 7, 2015, 4:01 a.m. UTC | #3
Hi Thomas,
Thomas Petazzoni wrote,

> Dear Waldemar Brodkorb,
> 
> On Wed, 6 May 2015 19:50:30 +0200, Waldemar Brodkorb wrote:
> > For mongrel2/libsigsegv we need to enable this in the uClibc-ng config.
> > Tested with ARM:
> > 
> > file output/target/usr/bin/mongrel2
> > output/target/usr/bin/mongrel2: ELF 32-bit LSB executable, ARM, version 1 (SYSV), dynamically linked (uses shared libs), stripped
> > 
> > Should fix:
> > http://autobuild.buildroot.net/results/a144bc6024415a5272c3cbe60ff636d078d0a555/
> > http://autobuild.buildroot.net/results/00195d89a115a314bf4916af127407f61cd1b418/
> > http://autobuild.buildroot.net/results/5ee7e83ebcfa43f6ee0a2a8b9f40f1ae84664aca/
> > 
> > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> > ---
> >  package/uclibc/uClibc-ng.config |    1 +
> >  1 file changed, 1 insertion(+)
> 
> We don't have this option enabled in uClibc-0.9.33.config. Should I
> assume that it's because this option doesn't exist in the 0.9.33.x
> uClibc branch?

Right, it was added later:
http://git.uclibc.org/uClibc/commit/extra/Configs/Config.in?id=a8dc90eaaa5e6474beac828558d969b1aafee4af
 
> Also, why don't we have this option enabled in uClibc-snapshot.config?

I don't know how often this file get updated?
 
BTW: These functions are only available for arm/mips/x86/x86_64.

So mongrel2/libsigsegv need to be fixed to these, when uClibc is
choosen.

best regards
 Waldemar
Thomas Petazzoni May 7, 2015, 7:25 a.m. UTC | #4
Dear Waldemar Brodkorb,

On Thu, 7 May 2015 06:01:16 +0200, Waldemar Brodkorb wrote:

> > We don't have this option enabled in uClibc-0.9.33.config. Should I
> > assume that it's because this option doesn't exist in the 0.9.33.x
> > uClibc branch?
> 
> Right, it was added later:
> http://git.uclibc.org/uClibc/commit/extra/Configs/Config.in?id=a8dc90eaaa5e6474beac828558d969b1aafee4af

Ok, thanks.

> > Also, why don't we have this option enabled in uClibc-snapshot.config?
> 
> I don't know how often this file get updated?

I'd say quite regularly, since it is used for the ARC and Xtensa builds.

Can you send an updated version of your patch that also updates
uClibc-snapshot.config ?

Thanks a lot!

Thomas
diff mbox

Patch

diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config
index c6e7ff9..b1f039a 100644
--- a/package/uclibc/uClibc-ng.config
+++ b/package/uclibc/uClibc-ng.config
@@ -117,6 +117,7 @@  UCLIBC_DYNAMIC_ATEXIT=y
 # COMPAT_ATEXIT is not set
 UCLIBC_SUSV2_LEGACY=y
 UCLIBC_SUSV3_LEGACY=y
+UCLIBC_HAS_CONTEXT_FUNCS=y
 # UCLIBC_SUSV3_LEGACY_MACROS is not set
 UCLIBC_SUSV4_LEGACY=y
 # UCLIBC_STRICT_HEADERS is not set