Patchwork [10/10] documentation: qemu_write_full don't work with non-blocking fd's

login
register
mail settings
Submitter Juan Quintela
Date March 4, 2010, 9 a.m.
Message ID <cbc3ce901197186aa4093bdd8bbec2424f8f4eff.1267692964.git.quintela@redhat.com>
Download mbox | patch
Permalink /patch/46900/
State New
Headers show

Comments

Juan Quintela - March 4, 2010, 9 a.m.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 osdep.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Patch

diff --git a/osdep.c b/osdep.c
index 5bf3c00..abbc8a2 100644
--- a/osdep.c
+++ b/osdep.c
@@ -261,6 +261,11 @@  int qemu_open(const char *name, int flags, ...)
  *
  * Return the number of bytes transferred.
  * Set errno if fewer than `count' bytes are written.
+ *
+ * This function don't work with non-blocking fd's.
+ * Any of the possibilities with non-bloking fd's is bad:
+ *   - return a short write (then name is wrong)
+ *   - busy wait adding (errno == EAGAIN) to the loop
  */
 ssize_t qemu_write_full(int fd, const void *buf, size_t count)
 {