From patchwork Thu Mar 4 09:00:31 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [02/10] slirp: check system() success Date: Wed, 03 Mar 2010 23:00:31 -0000 From: Juan Quintela X-Patchwork-Id: 46891 Message-Id: <93c1dcb48b0cfa33775fc45a1ffb9c0edb44d833.1267692963.git.quintela@redhat.com> To: qemu-devel@nongnu.org we shouldn't call W*() macros until we check that fork worked. Signed-off-by: Juan Quintela Acked-by: Michael S. Tsirkin --- net/slirp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index 317cca7..7f846ec 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -472,7 +472,7 @@ static void slirp_smb_cleanup(SlirpState *s) if (s->smb_dir[0] != '\0') { snprintf(cmd, sizeof(cmd), "rm -rf %s", s->smb_dir); ret = system(cmd); - if (!WIFEXITED(ret)) { + if (ret == -1 || !WIFEXITED(ret)) { qemu_error("'%s' failed.\n", cmd); } else if (WEXITSTATUS(ret)) { qemu_error("'%s' failed. Error code: %d\n",