Patchwork cxgb3: fix hot plug removal crash

login
register
mail settings
Submitter Divy Le Ray
Date March 3, 2010, 7:49 p.m.
Message ID <20100303194947.31628.5933.stgit@speedy5.asicdesigners.com>
Download mbox | patch
Permalink /patch/46874/
State Accepted
Delegated to: David Miller
Headers show

Comments

Divy Le Ray - March 3, 2010, 7:49 p.m.
From: Divy Le Ray <divy@chelsio.com>

queue restart tasklets need to be stopped after napi handlers are stopped
since the latter can restart them.  So stop them after stopping napi.

Signed-off-by: Divy Le Ray <divy@chelsio.com>
---

 drivers/net/cxgb3/cxgb3_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 4, 2010, 8:39 a.m.
From: Divy Le Ray <divy@chelsio.com>
Date: Wed, 03 Mar 2010 11:49:47 -0800

> From: Divy Le Ray <divy@chelsio.com>
> 
> queue restart tasklets need to be stopped after napi handlers are stopped
> since the latter can restart them.  So stop them after stopping napi.
> 
> Signed-off-by: Divy Le Ray <divy@chelsio.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index 6fd968a..cecdec1 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -1280,6 +1280,7 @@  static void cxgb_down(struct adapter *adapter)
 
 	free_irq_resources(adapter);
 	quiesce_rx(adapter);
+	t3_sge_stop(adapter);
 	flush_workqueue(cxgb3_wq);	/* wait for external IRQ handler */
 }