| Message ID | 5549CC2E.2060605@arm.com |
|---|---|
| State | New |
| Headers | show |
Ping~ Anybody can review this? Thank you! Regards, Renlin Li On 06/05/15 09:09, Renlin Li wrote: > Hi all, > > This is a simple patch to add _GLIBCXX_HAVE_LIMIT_FSIZE to guard the > test. > > In libstdc++-v3/testsuite/util/testsuite_hooks.cc. set_file_limit() > function is nullified when either _GLIBCXX_RES_LIMITS or > _GLIBCXX_HAVE_LIMIT_FSIZE is not defined. > _GLIBCXX_USE_LFS can cover _GLIBCXX_RES_LIMITS, however, > _GLIBCXX_HAVE_LIMIT_FSIZE is not checked. > > The complete condition for correct execution of this test case is > that, those two macros are both defined. > > Is Okay to commit? > > Regards, > Renlin Li > > libstdc++-v3/ChangeLog: > > 2015-05-06 Renlin Li <renlin.li@arm.com> > > * testsuite/27_io/fpos/14775.cc: Add _GLIBCXX_HAVE_LIMIT_FSIZE check.
On 06/05/15 09:09 +0100, Renlin Li wrote: >Hi all, > >This is a simple patch to add _GLIBCXX_HAVE_LIMIT_FSIZE to guard the test. > >In libstdc++-v3/testsuite/util/testsuite_hooks.cc. set_file_limit() >function is nullified when either _GLIBCXX_RES_LIMITS or >_GLIBCXX_HAVE_LIMIT_FSIZE is not defined. >_GLIBCXX_USE_LFS can cover _GLIBCXX_RES_LIMITS, however, >_GLIBCXX_HAVE_LIMIT_FSIZE is not checked. > >The complete condition for correct execution of this test case is >that, those two macros are both defined. > >Is Okay to commit? OK. >Regards, >Renlin Li > >libstdc++-v3/ChangeLog: > >2015-05-06 Renlin Li <renlin.li@arm.com> > > * testsuite/27_io/fpos/14775.cc: Add _GLIBCXX_HAVE_LIMIT_FSIZE check. >diff --git a/libstdc++-v3/testsuite/27_io/fpos/14775.cc b/libstdc++-v3/testsuite/27_io/fpos/14775.cc >index b700868..69c0a6a 100644 >--- a/libstdc++-v3/testsuite/27_io/fpos/14775.cc >+++ b/libstdc++-v3/testsuite/27_io/fpos/14775.cc >@@ -27,7 +27,7 @@ > // Basic test for LFS support. > void test01() > { >-#ifdef _GLIBCXX_USE_LFS >+#if defined (_GLIBCXX_USE_LFS) && defined (_GLIBCXX_HAVE_LIMIT_FSIZE) > using namespace std; > bool test __attribute__((unused)) = true; >
Hi Jonathan, I have committed it on trunk. Is it Okay for me to backport it to branch 5.0, 4.9 to remove failing noise? Regards, Renlin Li On 01/06/15 16:58, Jonathan Wakely wrote: > On 06/05/15 09:09 +0100, Renlin Li wrote: >> Hi all, >> >> This is a simple patch to add _GLIBCXX_HAVE_LIMIT_FSIZE to guard the test. >> >> In libstdc++-v3/testsuite/util/testsuite_hooks.cc. set_file_limit() >> function is nullified when either _GLIBCXX_RES_LIMITS or >> _GLIBCXX_HAVE_LIMIT_FSIZE is not defined. >> _GLIBCXX_USE_LFS can cover _GLIBCXX_RES_LIMITS, however, >> _GLIBCXX_HAVE_LIMIT_FSIZE is not checked. >> >> The complete condition for correct execution of this test case is >> that, those two macros are both defined. >> >> Is Okay to commit? > OK. > >> Regards, >> Renlin Li >> >> libstdc++-v3/ChangeLog: >> >> 2015-05-06 Renlin Li <renlin.li@arm.com> >> >> * testsuite/27_io/fpos/14775.cc: Add _GLIBCXX_HAVE_LIMIT_FSIZE check. >> diff --git a/libstdc++-v3/testsuite/27_io/fpos/14775.cc b/libstdc++-v3/testsuite/27_io/fpos/14775.cc >> index b700868..69c0a6a 100644 >> --- a/libstdc++-v3/testsuite/27_io/fpos/14775.cc >> +++ b/libstdc++-v3/testsuite/27_io/fpos/14775.cc >> @@ -27,7 +27,7 @@ >> // Basic test for LFS support. >> void test01() >> { >> -#ifdef _GLIBCXX_USE_LFS >> +#if defined (_GLIBCXX_USE_LFS) && defined (_GLIBCXX_HAVE_LIMIT_FSIZE) >> using namespace std; >> bool test __attribute__((unused)) = true; >>
On 4 June 2015 at 16:29, Renlin Li wrote: > Hi Jonathan, > > I have committed it on trunk. > > Is it Okay for me to backport it to branch 5.0, 4.9 to remove failing noise? I accidentally replied off-list yesterday. Backporting this is OK, thanks.
diff --git a/libstdc++-v3/testsuite/27_io/fpos/14775.cc b/libstdc++-v3/testsuite/27_io/fpos/14775.cc index b700868..69c0a6a 100644 --- a/libstdc++-v3/testsuite/27_io/fpos/14775.cc +++ b/libstdc++-v3/testsuite/27_io/fpos/14775.cc @@ -27,7 +27,7 @@ // Basic test for LFS support. void test01() { -#ifdef _GLIBCXX_USE_LFS +#if defined (_GLIBCXX_USE_LFS) && defined (_GLIBCXX_HAVE_LIMIT_FSIZE) using namespace std; bool test __attribute__((unused)) = true;
Hi all, This is a simple patch to add _GLIBCXX_HAVE_LIMIT_FSIZE to guard the test. In libstdc++-v3/testsuite/util/testsuite_hooks.cc. set_file_limit() function is nullified when either _GLIBCXX_RES_LIMITS or _GLIBCXX_HAVE_LIMIT_FSIZE is not defined. _GLIBCXX_USE_LFS can cover _GLIBCXX_RES_LIMITS, however, _GLIBCXX_HAVE_LIMIT_FSIZE is not checked. The complete condition for correct execution of this test case is that, those two macros are both defined. Is Okay to commit? Regards, Renlin Li libstdc++-v3/ChangeLog: 2015-05-06 Renlin Li <renlin.li@arm.com> * testsuite/27_io/fpos/14775.cc: Add _GLIBCXX_HAVE_LIMIT_FSIZE check.