diff mbox

[U-Boot] fsl/sata: Replace sprintf() with snprintf()

Message ID 1430880903-10323-1-git-send-email-Yuantian.Tang@freescale.com
State Superseded
Headers show

Commit Message

tang yuantian May 6, 2015, 2:55 a.m. UTC 
From: Tang Yuantian <Yuantian.Tang@freescale.com>

Function 'sprintf' does not check buffer boundaries but outputs
to the buffer of fixed size which could cause buffer overflow.
Use a safer function to replace it.

Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
 drivers/block/fsl_sata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/drivers/block/fsl_sata.c b/drivers/block/fsl_sata.c
index 71d7cec..e720c3e 100644
--- a/drivers/block/fsl_sata.c
+++ b/drivers/block/fsl_sata.c
@@ -113,7 +113,7 @@  int init_sata(int dev)
 	/* Save the private struct to block device struct */
 	sata_dev_desc[dev].priv = (void *)sata;
 
-	sprintf(sata->name, "SATA%d", dev);
+	snprintf(sata->name, 7, "SATA%d", dev);
 
 	/* Set the controller register base address to device struct */
 	reg = (fsl_sata_reg_t *)(fsl_sata_info[dev].sata_reg_base);