ARM: EXYNOS: Fixes for 4.1
mbox

Message ID 1430873718-22726-1-git-send-email-k.kozlowski@samsung.com
State New
Headers show

Pull-request

https://github.com/krzk/linux.git tags/samsung-fixes-4.1

Message

Krzysztof Kozlowski May 6, 2015, 12:55 a.m. UTC
Dear Kukjin,

This groups important fix for current RC cycle. The patch was present
on mailing list for quite long. It was tested. We had some
disagreements about the solution but during discussion better ways for
solving the issue were not presented.

Best regards,
Krzysztof

----------------------------------------------------------------

The following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22:

  Linux 4.1-rc2 (2015-05-03 19:22:23 -0700)

are available in the git repository at:

  https://github.com/krzk/linux.git tags/samsung-fixes-4.1

for you to fetch changes up to 23e15018316e949c534cc32e46502f3080dfc970:

  ARM: EXYNOS: Fix failed second suspend on Exynos4 (2015-05-05 19:17:58 +0900)

----------------------------------------------------------------
Fixes failed second suspend to RAM on Exynos4412 based Trats2 board. This has
shown up after enabling L2 cache but actually the "use delayed reset assertion"
feature is to be blamed.

----------------------------------------------------------------
Krzysztof Kozlowski (1):
      ARM: EXYNOS: Fix failed second suspend on Exynos4

 arch/arm/mach-exynos/common.h  |  2 ++
 arch/arm/mach-exynos/exynos.c  | 27 +++++++++++++++++++++++++++
 arch/arm/mach-exynos/platsmp.c | 39 ++-------------------------------------
 arch/arm/mach-exynos/suspend.c |  3 +++
 4 files changed, 34 insertions(+), 37 deletions(-)

Comments

'Kukjin Kim' May 8, 2015, 6:26 p.m. UTC | #1
On 05/06/15 09:55, Krzysztof Kozlowski wrote:
> Dear Kukjin,
> 
> This groups important fix for current RC cycle. The patch was present
> on mailing list for quite long. It was tested. We had some
> disagreements about the solution but during discussion better ways for
> solving the issue were not presented.
> 
> Best regards,
> Krzysztof
> 
> ----------------------------------------------------------------
> 
> The following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22:
> 
>   Linux 4.1-rc2 (2015-05-03 19:22:23 -0700)
> 
> are available in the git repository at:
> 
>   https://github.com/krzk/linux.git tags/samsung-fixes-4.1
> 
> for you to fetch changes up to 23e15018316e949c534cc32e46502f3080dfc970:
> 
>   ARM: EXYNOS: Fix failed second suspend on Exynos4 (2015-05-05 19:17:58 +0900)
> 
> ----------------------------------------------------------------
> Fixes failed second suspend to RAM on Exynos4412 based Trats2 board. This has
> shown up after enabling L2 cache but actually the "use delayed reset assertion"
> feature is to be blamed.
> 
> ----------------------------------------------------------------
> Krzysztof Kozlowski (1):
>       ARM: EXYNOS: Fix failed second suspend on Exynos4
> 
>  arch/arm/mach-exynos/common.h  |  2 ++
>  arch/arm/mach-exynos/exynos.c  | 27 +++++++++++++++++++++++++++
>  arch/arm/mach-exynos/platsmp.c | 39 ++-------------------------------------
>  arch/arm/mach-exynos/suspend.c |  3 +++
>  4 files changed, 34 insertions(+), 37 deletions(-)
> --

Hi Krzysztof,

Yeah, the patch is old thing but if I remember correctly, I couldn't
apply it because of soc_is_xxx() macro. Yes, I agree with the way,
firstly fix something and if required, then update it later....But!

Please address comments about that, if not, it will not be accepted by
arm-soc tree.

Thanks,
Kukjin
Krzysztof Kozlowski May 9, 2015, 12:42 a.m. UTC | #2
2015-05-09 3:26 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
> On 05/06/15 09:55, Krzysztof Kozlowski wrote:
>> Krzysztof Kozlowski (1):
>>       ARM: EXYNOS: Fix failed second suspend on Exynos4
>>
>>  arch/arm/mach-exynos/common.h  |  2 ++
>>  arch/arm/mach-exynos/exynos.c  | 27 +++++++++++++++++++++++++++
>>  arch/arm/mach-exynos/platsmp.c | 39 ++-------------------------------------
>>  arch/arm/mach-exynos/suspend.c |  3 +++
>>  4 files changed, 34 insertions(+), 37 deletions(-)
>> --
>
> Hi Krzysztof,
>
> Yeah, the patch is old thing but if I remember correctly, I couldn't
> apply it because of soc_is_xxx() macro. Yes, I agree with the way,
> firstly fix something and if required, then update it later....But!
>
> Please address comments about that, if not, it will not be accepted by
> arm-soc tree.

Hi,

Actually during previous discussion I addressed all the issues:
https://lkml.org/lkml/2015/3/18/108
but there was no response from your side.

In previous thread you also asked about proper way of using the
DELAYED_RESET_ASSERTION. I tried to obtain additional docs from LSI
but couldn't. In current documentation it was described vaguely so I
looked at vendor source code. The patch IMHO is the best solution.
Additionally it was tested (Chanwoo and Bartlomiej) and fixes the
issue.

As for the soc_is_exynos -> of_machine_is_compatible I will prepare a
follow up to fix this.

Let me know if you have any other comments about it.

Best regards,
Krzysztof