diff mbox

[U-Boot,11/16] usb: ohci: Don't log an error on interrupt packet timeout

Message ID 1430862979-4684-12-git-send-email-hdegoede@redhat.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Hans de Goede May 5, 2015, 9:56 p.m. UTC 
Interrupts transfers timing out is normal, so do not log an error for this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/usb/host/ohci-hcd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Marek Vasut May 5, 2015, 10:59 p.m. UTC | #1 
On Tuesday, May 05, 2015 at 11:56:14 PM, Hans de Goede wrote:
> Interrupts transfers timing out is normal, so do not log an error for this.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut
Simon Glass May 6, 2015, 9:44 p.m. UTC | #2 
On 5 May 2015 at 16:59, Marek Vasut <marex@denx.de> wrote:
> On Tuesday, May 05, 2015 at 11:56:14 PM, Hans de Goede wrote:
>> Interrupts transfers timing out is normal, so do not log an error for this.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Marek Vasut <marex@denx.de>

Applied to u-boot-dm, thanks!
diff mbox

Patch

diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index 3744658..494b760 100644
--- a/drivers/usb/host/ohci-hcd.c
+++ b/drivers/usb/host/ohci-hcd.c
@@ -1572,7 +1572,8 @@  static int submit_common_msg(ohci_t *ohci, struct usb_device *dev,
 				dbg("*");
 
 		} else {
-			err("CTL:TIMEOUT ");
+			if (!usb_pipeint(pipe))
+				err("CTL:TIMEOUT ");
 			dbg("submit_common_msg: TO status %x\n", stat);
 			urb->finished = 1;
 			stat = USB_ST_CRC_ERR;