Patchwork [Lucid,pre-stable] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m

login
register
mail settings
Submitter Surbhi Palande
Date March 3, 2010, 6:13 p.m.
Message ID <1267639990-13168-1-git-send-email-surbhi.palande@canonical.com>
Download mbox | patch
Permalink /patch/46850/
State Accepted
Delegated to: Andy Whitcroft
Headers show

Comments

Surbhi Palande - March 3, 2010, 6:13 p.m.
This patch is a simple fix for the error "no connectors reported" seen by
users with the Sony VGN-BX196VP and Dell Inspiron 700m laptops. This patch 
has been posted upstream for review. It has been tested by two users who
reported this bug on launchpad: bug 515246.

Please do consider merging it in Lucid.

The following changes since commit ff8c647d55b153564d55683b805ec0fc8ea3f1a1:
  Andy Whitcroft (1):
        UBUNTU: Start new release

are available in the git repository at:

  git://kernel.ubuntu.com/surbhi/ubuntu-lucid.git lp515246-lid

Surbhi Palande (1):
      drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m

 drivers/gpu/drm/i915/intel_lvds.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

From 8b66c175c967cb823ef3437745531e662b0b82d8 Mon Sep 17 00:00:00 2001
From: Surbhi Palande <surbhi.palande@canonical.com>
Date: Mon, 22 Feb 2010 22:39:28 +0200
Subject: [PATCH] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m

BugLink: https://bugs.launchpad.net/bugs/515246

Sony VGN-BX196VP and Dell Inspiron 700m report lid status as closed
when it is open. This leads to a "no connectors reported" error at startup.
Blacklisting them to always return a connected status for the default
lvds connector.

Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
---
 drivers/gpu/drm/i915/intel_lvds.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
Tim Gardner - March 3, 2010, 6:31 p.m.
Surbhi Palande wrote:
> This patch is a simple fix for the error "no connectors reported" seen by
> users with the Sony VGN-BX196VP and Dell Inspiron 700m laptops. This patch 
> has been posted upstream for review. It has been tested by two users who
> reported this bug on launchpad: bug 515246.
> 
> Please do consider merging it in Lucid.
> 
> The following changes since commit ff8c647d55b153564d55683b805ec0fc8ea3f1a1:
>   Andy Whitcroft (1):
>         UBUNTU: Start new release
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/surbhi/ubuntu-lucid.git lp515246-lid
> 
> Surbhi Palande (1):
>       drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m
> 
>  drivers/gpu/drm/i915/intel_lvds.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> From 8b66c175c967cb823ef3437745531e662b0b82d8 Mon Sep 17 00:00:00 2001
> From: Surbhi Palande <surbhi.palande@canonical.com>
> Date: Mon, 22 Feb 2010 22:39:28 +0200
> Subject: [PATCH] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m
> 
> BugLink: https://bugs.launchpad.net/bugs/515246
> 
> Sony VGN-BX196VP and Dell Inspiron 700m report lid status as closed
> when it is open. This leads to a "no connectors reported" error at startup.
> Blacklisting them to always return a connected status for the default
> lvds connector.
> 
> Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
> ---
>  drivers/gpu/drm/i915/intel_lvds.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 33eed69..facafc1 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -608,6 +608,19 @@ static const struct dmi_system_id bad_lid_status[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire one"),
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "VGN-BX196VP"),
> +		},
> +	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 700m"),
> +		},
> +	},
> +
>  	{ }
>  };
>  

Its worth noting that this will likely be a stable update (eventually).

rtg
Tim Gardner - March 3, 2010, 7:44 p.m.
On 03/03/2010 11:31 AM, Tim Gardner wrote:
>
> Its worth noting that this will likely be a stable update (eventually).
>
> rtg

Which should be obvious from the subject. Doh!
Andy Whitcroft - March 3, 2010, 9:15 p.m.
Minor collission with something from stable by the looks of it, I've
fixed it up and applied it.

Applied to Lucid.

-apw

Patch

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index 33eed69..facafc1 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -608,6 +608,19 @@  static const struct dmi_system_id bad_lid_status[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire one"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "VGN-BX196VP"),
+		},
+	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 700m"),
+		},
+	},
+
 	{ }
 };