| Message ID | 1430862979-4684-4-git-send-email-hdegoede@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
On Tuesday, May 05, 2015 at 11:56:06 PM, Hans de Goede wrote: > devgone is never assigned a value, so the one comparisson reading it will > never be true, and devgone can be completely removed. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Marek Vasut <marex@denx.de> Best regards, Marek Vasut
On 5 May 2015 at 16:55, Marek Vasut <marex@denx.de> wrote: > On Tuesday, May 05, 2015 at 11:56:06 PM, Hans de Goede wrote: >> devgone is never assigned a value, so the one comparisson reading it will >> never be true, and devgone can be completely removed. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > Acked-by: Marek Vasut <marex@denx.de> Applied to u-boot-dm, thanks!
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index 97a7ede..81ef8ef 100644 --- a/drivers/usb/host/ohci-hcd.c +++ b/drivers/usb/host/ohci-hcd.c @@ -111,8 +111,6 @@ struct ohci_hcca ghcca[1]; struct ohci_hcca *phcca; /* this allocates EDs for all possible endpoints */ struct ohci_device ohci_dev; -/* device which was disconnected */ -struct usb_device *devgone; static inline u32 roothub_a(struct ohci *hc) { return ohci_readl(&hc->regs->roothub.a); } @@ -1380,12 +1378,6 @@ int submit_common_msg(struct usb_device *dev, unsigned long pipe, void *buffer, urb->transfer_buffer_length = transfer_len; urb->interval = interval; - /* device pulled? Shortcut the action. */ - if (devgone == dev) { - dev->status = USB_ST_CRC_ERR; - return 0; - } - #ifdef DEBUG urb->actual_length = 0; pkt_print(urb, dev, pipe, buffer, transfer_len,
devgone is never assigned a value, so the one comparisson reading it will never be true, and devgone can be completely removed. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/usb/host/ohci-hcd.c | 8 -------- 1 file changed, 8 deletions(-)