diff mbox

[PATCHv2] package/neard: needs shared libs

Message ID 1430777547-30022-1-git-send-email-yann.morin.1998@free.fr
State Accepted
Commit c61c3d3d4b9e1b97418c2c3699ec2943d76ef295
Headers show

Commit Message

Yann E. MORIN May 4, 2015, 10:12 p.m. UTC
neard uses dlopen(), so needs shared libs.

Fixes:
    http://autobuild.buildroot.org/results/0a4/0a466cde55c5e128a2e201924f80f0ec6b8b5c2a/

Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

---
Changes v1 -> v2:
  - update comment

---
Note: the only package that selects neard is connman, and it already
depends on !static.
---
 package/neard/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard May 5, 2015, 3:13 p.m. UTC | #1
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > neard uses dlopen(), so needs shared libs.
 > Fixes:
 >     http://autobuild.buildroot.org/results/0a4/0a466cde55c5e128a2e201924f80f0ec6b8b5c2a/

 > Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

 > ---
 > Changes v1 -> v2:
 >   - update comment

 > ---
 > Note: the only package that selects neard is connman, and it already
 > depends on !static.

Committed, thanks.
diff mbox

Patch

diff --git a/package/neard/Config.in b/package/neard/Config.in
index ed20e06..353d1af 100644
--- a/package/neard/Config.in
+++ b/package/neard/Config.in
@@ -3,6 +3,7 @@  config BR2_PACKAGE_NEARD
 	depends on BR2_USE_WCHAR # libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl, dbus, libglib2
 	depends on BR2_USE_MMU # dbus, libglib2
+	depends on !BR2_STATIC_LIBS # dlopen
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_LIBNL
@@ -23,6 +24,6 @@  config BR2_PACKAGE_NEARD_TOOLS
 
 endif
 
-comment "neard needs a toolchain w/ wchar, threads"
+comment "neard needs a toolchain w/ wchar, threads, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS