| Message ID | 1430597796-23584-1-git-send-email-romain.naour@openwide.fr |
|---|---|
| State | Accepted |
| Headers | show |
Dear Romain Naour, On Sat, 2 May 2015 22:16:36 +0200, Romain Naour wrote: > evas_engine_software_xlib_cflags and evas_engine_software_xlib_libs > contains unsafe libraries paths if x-include and x-libraries are > not set in libevas.mk. > > config.log: > evas_engine_software_xlib_cflags='-I/usr/X11R6/include' > evas_engine_software_xlib_libs='-L/usr/X11R6/lib -lX11 -lXext' > > Fixes: > http://autobuild.buildroot.net/results/e5f/e5fb1e62cb634b20233751b4ea3b0630de70e9e0/ > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> > --- > package/efl/libevas/libevas.mk | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Applied, thanks. I've done a second commit on libecore with the exact same fix, because the exact same problem occurred on libecore in my test build. See http://git.buildroot.net/buildroot/commit/?id=0d9d8984a9240a27f5ed2e15f1977ada67266906. Best regards, Thomas
Hi Thomas, Le 03/05/2015 11:46, Thomas Petazzoni a écrit : > Dear Romain Naour, > > On Sat, 2 May 2015 22:16:36 +0200, Romain Naour wrote: >> evas_engine_software_xlib_cflags and evas_engine_software_xlib_libs >> contains unsafe libraries paths if x-include and x-libraries are >> not set in libevas.mk. >> >> config.log: >> evas_engine_software_xlib_cflags='-I/usr/X11R6/include' >> evas_engine_software_xlib_libs='-L/usr/X11R6/lib -lX11 -lXext' >> >> Fixes: >> http://autobuild.buildroot.net/results/e5f/e5fb1e62cb634b20233751b4ea3b0630de70e9e0/ >> >> Signed-off-by: Romain Naour <romain.naour@openwide.fr> >> --- >> package/efl/libevas/libevas.mk | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Applied, thanks. I've done a second commit on libecore with the exact > same fix, because the exact same problem occurred on libecore in my > test build. See > http://git.buildroot.net/buildroot/commit/?id=0d9d8984a9240a27f5ed2e15f1977ada67266906. This is what this path does ;) http://patchwork.ozlabs.org/patch/467259/ Thanks for fixing this. Best regards, Romain > > Best regards, > > Thomas >
Dear Romain Naour, On Sun, 03 May 2015 12:00:48 +0200, Romain Naour wrote: > This is what this path does ;) > http://patchwork.ozlabs.org/patch/467259/ Ah, shit, I messed up. I marked this patch as superseded because for me it was an incorrect previous version of the libevas patch. Sorry about that :-/ Thomas
Hi Thomas, Le 03/05/2015 12:15, Thomas Petazzoni a écrit : > Dear Romain Naour, > > On Sun, 03 May 2015 12:00:48 +0200, Romain Naour wrote: > >> This is what this path does ;) >> http://patchwork.ozlabs.org/patch/467259/ > > Ah, shit, I messed up. I marked this patch as superseded because for me > it was an incorrect previous version of the libevas patch. Sorry about > that :-/ No problem at all :) I only marked the first patch as Rejected in the patchwork. I had to send the complete series, instead of send a separate patch. Best regards, Romain > > Thomas >
diff --git a/package/efl/libevas/libevas.mk b/package/efl/libevas/libevas.mk index 8312902..8113162 100644 --- a/package/efl/libevas/libevas.mk +++ b/package/efl/libevas/libevas.mk @@ -63,7 +63,10 @@ LIBEVAS_CONF_OPTS += --enable-buffer endif ifeq ($(BR2_PACKAGE_LIBEVAS_X11),y) -LIBEVAS_CONF_OPTS += --enable-software-xlib +LIBEVAS_CONF_OPTS += --enable-software-xlib \ + --with-x=$(STAGING_DIR) \ + --x-includes=$(STAGING_DIR)/usr/include \ + --x-libraries=$(STAGING_DIR)/usr/lib LIBEVAS_DEPENDENCIES += xlib_libX11 xlib_libXext else LIBEVAS_CONF_OPTS += --disable-software-xlib
evas_engine_software_xlib_cflags and evas_engine_software_xlib_libs contains unsafe libraries paths if x-include and x-libraries are not set in libevas.mk. config.log: evas_engine_software_xlib_cflags='-I/usr/X11R6/include' evas_engine_software_xlib_libs='-L/usr/X11R6/lib -lX11 -lXext' Fixes: http://autobuild.buildroot.net/results/e5f/e5fb1e62cb634b20233751b4ea3b0630de70e9e0/ Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- package/efl/libevas/libevas.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)