diff mbox

[2/2] package/argp-standalone: is useless for (e)glibc toolchains

Message ID 1430562486-23625-2-git-send-email-romain.naour@openwide.fr
State Accepted
Commit 3d1807f935b10001b9703c9614f3cd4f9b14d69e
Headers show

Commit Message

Romain Naour May 2, 2015, 10:28 a.m. UTC
According to Thomas's remark [1], (e)glibc toolchains provide it's
own argp.h version.
Also, it appears that argp.h from glibc is more up to date should
be preferred to argp-standalone one.

[1] http://lists.busybox.net/pipermail/buildroot/2015-May/127511.html

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
Note: I didn't add a comment in Config.in to tell that argp-standalone
      package is useless for (e)glibc toolchains.
---
 package/argp-standalone/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Peter Korsgaard May 3, 2015, 5:21 p.m. UTC | #1
>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes:

 > According to Thomas's remark [1], (e)glibc toolchains provide it's
 > own argp.h version.
 > Also, it appears that argp.h from glibc is more up to date should
 > be preferred to argp-standalone one.

 > [1] http://lists.busybox.net/pipermail/buildroot/2015-May/127511.html

 > Signed-off-by: Romain Naour <romain.naour@openwide.fr>
 > ---
 > Note: I didn't add a comment in Config.in to tell that argp-standalone
 >       package is useless for (e)glibc toolchains.

I think it is OK to not display anything as it doesn't make sense on
glibc.

Committed, thanks.
diff mbox

Patch

diff --git a/package/argp-standalone/Config.in b/package/argp-standalone/Config.in
index 5a0c051..3319dd9 100644
--- a/package/argp-standalone/Config.in
+++ b/package/argp-standalone/Config.in
@@ -1,5 +1,7 @@ 
 config BR2_PACKAGE_ARGP_STANDALONE
 	bool "argp-standalone"
+	# glibc provides its own argp implementation.
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
 	help
 	  Glibc hierarchical argument parsing standalone library.