diff mbox

[U-Boot,1/2] stv0991: fdt: add stv0991 device tree

Message ID 1430520185-10090-2-git-send-email-vikas.manocha@st.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Vikas MANOCHA May 1, 2015, 10:43 p.m. UTC 
Signed-off-by: Vikas Manocha <vikas.manocha@st.com>
---
 arch/arm/dts/Makefile     |    1 +
 arch/arm/dts/stv0991.dts  |   23 +++++++++++++++++++++++
 configs/stv0991_defconfig |    1 +
 include/configs/stv0991.h |    3 +++
 4 files changed, 28 insertions(+)
 create mode 100644 arch/arm/dts/stv0991.dts

Comments

Simon Glass May 1, 2015, 11:01 p.m. UTC | #1 
Hi Vikas,

On 1 May 2015 at 16:43, Vikas Manocha <vikas.manocha@st.com> wrote:

<commit message here>

> Signed-off-by: Vikas Manocha <vikas.manocha@st.com>
> ---
>  arch/arm/dts/Makefile     |    1 +
>  arch/arm/dts/stv0991.dts  |   23 +++++++++++++++++++++++
>  configs/stv0991_defconfig |    1 +
>  include/configs/stv0991.h |    3 +++
>  4 files changed, 28 insertions(+)
>  create mode 100644 arch/arm/dts/stv0991.dts
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 46a6171..86faf58 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -54,6 +54,7 @@ dtb-$(CONFIG_SOCFPGA) +=                              \
>         socfpga_arria5_socdk.dtb                        \
>         socfpga_cyclone5_socdk.dtb                      \
>         socfpga_cyclone5_socrates.dtb
> +dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb

Is this the only chip in this soc family? If so fine. If not, could
your CONFIG be a little broader so we can (later) list all the DTBs
here?

>
>  dtb-$(CONFIG_LS102XA) += ls1021a-qds.dtb \
>         ls1021a-twr.dtb
> diff --git a/arch/arm/dts/stv0991.dts b/arch/arm/dts/stv0991.dts
> new file mode 100644
> index 0000000..b25c48b
> --- /dev/null
> +++ b/arch/arm/dts/stv0991.dts
> @@ -0,0 +1,23 @@
> +/dts-v1/;
> +
> +/ {
> +       model = "ST STV0991 application board";
> +       compatible = "st,stv0991";
> +       #address-cells = <1>;
> +       #size-cells = <1>;
> +
> +       chosen {
> +               stdout-path = &uart0;
> +       };
> +
> +       memory {
> +               device_type="memory";
> +               reg = <0x0 0x198000>;
> +       };
> +
> +       uart0: serial@0x80406000 {
> +               compatible = "arm,pl011", "arm,primecell";
> +               reg = <0x80406000 0x1000>;
> +               clock = <2700000>;
> +       };
> +};
> diff --git a/configs/stv0991_defconfig b/configs/stv0991_defconfig
> index 76ba41b..d9edc06 100644
> --- a/configs/stv0991_defconfig
> +++ b/configs/stv0991_defconfig
> @@ -5,3 +5,4 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000
>  CONFIG_ETH_DESIGNWARE=y
>  CONFIG_NETDEVICES=y
>  CONFIG_NET=y
> +CONFIG_DEFAULT_DEVICE_TREE="stv0991"
> diff --git a/include/configs/stv0991.h b/include/configs/stv0991.h
> index 2f65eda..750eebd 100644
> --- a/include/configs/stv0991.h
> +++ b/include/configs/stv0991.h
> @@ -80,4 +80,7 @@
>  #define CONFIG_AUTOBOOT_PROMPT                 \
>         "Hit SPACE in %d seconds to stop autoboot.\n", bootdelay
>  #undef CONFIG_HAS_VBAR
> +#define CONFIG_OF_EMBED
> +#define CONFIG_OF_CONTROL
> +#define CONFIG_OF_LIBFDT
>  #endif /* __CONFIG_H */
> --
> 1.7.9.5
>

Regards,
Simon
Vikas MANOCHA May 1, 2015, 11:18 p.m. UTC | #2 
Thanks Simon,

On 05/01/2015 04:01 PM, Simon Glass wrote:
> Hi Vikas,
>
> On 1 May 2015 at 16:43, Vikas Manocha <vikas.manocha@st.com> wrote:
>
> <commit message here>

There is not much to add in the commit message apart from info in the title,
that is why i didn't add any message in the body.  Please let me know if i am
missing something ?

>
>> Signed-off-by: Vikas Manocha <vikas.manocha@st.com>
>> ---
>>  arch/arm/dts/Makefile     |    1 +
>>  arch/arm/dts/stv0991.dts  |   23 +++++++++++++++++++++++
>>  configs/stv0991_defconfig |    1 +
>>  include/configs/stv0991.h |    3 +++
>>  4 files changed, 28 insertions(+)
>>  create mode 100644 arch/arm/dts/stv0991.dts
>>
>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>> index 46a6171..86faf58 100644
>> --- a/arch/arm/dts/Makefile
>> +++ b/arch/arm/dts/Makefile
>> @@ -54,6 +54,7 @@ dtb-$(CONFIG_SOCFPGA) +=                              \
>>         socfpga_arria5_socdk.dtb                        \
>>         socfpga_cyclone5_socdk.dtb                      \
>>         socfpga_cyclone5_socrates.dtb
>> +dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb
> Is this the only chip in this soc family? If so fine. If not, could
> your CONFIG be a little broader so we can (later) list all the DTBs
> here?

Yes, it is the only chip :-(, hope there will be more.

Rgds,
Vikas

>>  dtb-$(CONFIG_LS102XA) += ls1021a-qds.dtb \
>>         ls1021a-twr.dtb
>> diff --git a/arch/arm/dts/stv0991.dts b/arch/arm/dts/stv0991.dts
>> new file mode 100644
>> index 0000000..b25c48b
>> --- /dev/null
>> +++ b/arch/arm/dts/stv0991.dts
>> @@ -0,0 +1,23 @@
>> +/dts-v1/;
>> +
>> +/ {
>> +       model = "ST STV0991 application board";
>> +       compatible = "st,stv0991";
>> +       #address-cells = <1>;
>> +       #size-cells = <1>;
>> +
>> +       chosen {
>> +               stdout-path = &uart0;
>> +       };
>> +
>> +       memory {
>> +               device_type="memory";
>> +               reg = <0x0 0x198000>;
>> +       };
>> +
>> +       uart0: serial@0x80406000 {
>> +               compatible = "arm,pl011", "arm,primecell";
>> +               reg = <0x80406000 0x1000>;
>> +               clock = <2700000>;
>> +       };
>> +};
>> diff --git a/configs/stv0991_defconfig b/configs/stv0991_defconfig
>> index 76ba41b..d9edc06 100644
>> --- a/configs/stv0991_defconfig
>> +++ b/configs/stv0991_defconfig
>> @@ -5,3 +5,4 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000
>>  CONFIG_ETH_DESIGNWARE=y
>>  CONFIG_NETDEVICES=y
>>  CONFIG_NET=y
>> +CONFIG_DEFAULT_DEVICE_TREE="stv0991"
>> diff --git a/include/configs/stv0991.h b/include/configs/stv0991.h
>> index 2f65eda..750eebd 100644
>> --- a/include/configs/stv0991.h
>> +++ b/include/configs/stv0991.h
>> @@ -80,4 +80,7 @@
>>  #define CONFIG_AUTOBOOT_PROMPT                 \
>>         "Hit SPACE in %d seconds to stop autoboot.\n", bootdelay
>>  #undef CONFIG_HAS_VBAR
>> +#define CONFIG_OF_EMBED
>> +#define CONFIG_OF_CONTROL
>> +#define CONFIG_OF_LIBFDT
>>  #endif /* __CONFIG_H */
>> --
>> 1.7.9.5
>>
> Regards,
> Simon
Vikas MANOCHA May 1, 2015, 11:43 p.m. UTC | #3 
Hi Simon,

On 05/01/2015 04:45 PM, Simon Glass wrote:
> Hi Vikas,
>
> On 1 May 2015 at 17:18, vikasm <vikas.manocha@st.com> wrote:
>> Thanks Simon,
>>
>> On 05/01/2015 04:01 PM, Simon Glass wrote:
>>> Hi Vikas,
>>>
>>> On 1 May 2015 at 16:43, Vikas Manocha <vikas.manocha@st.com> wrote:
>>>
>>> <commit message here>
>> There is not much to add in the commit message apart from info in the title,
>> that is why i didn't add any message in the body.  Please let me know if i am
>> missing something ?
> How about:
>
> "Add a device tree for the St Micro STV0991 board and enable device
> tree control. We will progressively add device tree support to drivers
> used by this board"

Thanks, i will send V2.

Rgds,
Vikas

>
>>>> Signed-off-by: Vikas Manocha <vikas.manocha@st.com>
>>>> ---
>>>>  arch/arm/dts/Makefile     |    1 +
>>>>  arch/arm/dts/stv0991.dts  |   23 +++++++++++++++++++++++
>>>>  configs/stv0991_defconfig |    1 +
>>>>  include/configs/stv0991.h |    3 +++
>>>>  4 files changed, 28 insertions(+)
>>>>  create mode 100644 arch/arm/dts/stv0991.dts
>>>>
>>>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>>>> index 46a6171..86faf58 100644
>>>> --- a/arch/arm/dts/Makefile
>>>> +++ b/arch/arm/dts/Makefile
>>>> @@ -54,6 +54,7 @@ dtb-$(CONFIG_SOCFPGA) +=                              \
>>>>         socfpga_arria5_socdk.dtb                        \
>>>>         socfpga_cyclone5_socdk.dtb                      \
>>>>         socfpga_cyclone5_socrates.dtb
>>>> +dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb
>>> Is this the only chip in this soc family? If so fine. If not, could
>>> your CONFIG be a little broader so we can (later) list all the DTBs
>>> here?
>> Yes, it is the only chip :-(, hope there will be more.
> OK.
>
>> Rgds,
>> Vikas
>>
>>>>  dtb-$(CONFIG_LS102XA) += ls1021a-qds.dtb \
>>>>         ls1021a-twr.dtb
>>>> diff --git a/arch/arm/dts/stv0991.dts b/arch/arm/dts/stv0991.dts
>>>> new file mode 100644
>>>> index 0000000..b25c48b
>>>> --- /dev/null
>>>> +++ b/arch/arm/dts/stv0991.dts
>>>> @@ -0,0 +1,23 @@
>>>> +/dts-v1/;
>>>> +
>>>> +/ {
>>>> +       model = "ST STV0991 application board";
>>>> +       compatible = "st,stv0991";
>>>> +       #address-cells = <1>;
>>>> +       #size-cells = <1>;
>>>> +
>>>> +       chosen {
>>>> +               stdout-path = &uart0;
>>>> +       };
>>>> +
>>>> +       memory {
>>>> +               device_type="memory";
>>>> +               reg = <0x0 0x198000>;
>>>> +       };
>>>> +
>>>> +       uart0: serial@0x80406000 {
>>>> +               compatible = "arm,pl011", "arm,primecell";
>>>> +               reg = <0x80406000 0x1000>;
>>>> +               clock = <2700000>;
>>>> +       };
>>>> +};
>>>> diff --git a/configs/stv0991_defconfig b/configs/stv0991_defconfig
>>>> index 76ba41b..d9edc06 100644
>>>> --- a/configs/stv0991_defconfig
>>>> +++ b/configs/stv0991_defconfig
>>>> @@ -5,3 +5,4 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000
>>>>  CONFIG_ETH_DESIGNWARE=y
>>>>  CONFIG_NETDEVICES=y
>>>>  CONFIG_NET=y
>>>> +CONFIG_DEFAULT_DEVICE_TREE="stv0991"
>>>> diff --git a/include/configs/stv0991.h b/include/configs/stv0991.h
>>>> index 2f65eda..750eebd 100644
>>>> --- a/include/configs/stv0991.h
>>>> +++ b/include/configs/stv0991.h
>>>> @@ -80,4 +80,7 @@
>>>>  #define CONFIG_AUTOBOOT_PROMPT                 \
>>>>         "Hit SPACE in %d seconds to stop autoboot.\n", bootdelay
>>>>  #undef CONFIG_HAS_VBAR
>>>> +#define CONFIG_OF_EMBED
>>>> +#define CONFIG_OF_CONTROL
>>>> +#define CONFIG_OF_LIBFDT
>>>>  #endif /* __CONFIG_H */
>>>> --
>>>> 1.7.9.5
>>>>
>>> Regards,
>>> Simon
> Regards,
> Simon
Simon Glass May 1, 2015, 11:45 p.m. UTC | #4 
Hi Vikas,

On 1 May 2015 at 17:18, vikasm <vikas.manocha@st.com> wrote:
> Thanks Simon,
>
> On 05/01/2015 04:01 PM, Simon Glass wrote:
>> Hi Vikas,
>>
>> On 1 May 2015 at 16:43, Vikas Manocha <vikas.manocha@st.com> wrote:
>>
>> <commit message here>
>
> There is not much to add in the commit message apart from info in the title,
> that is why i didn't add any message in the body.  Please let me know if i am
> missing something ?

How about:

"Add a device tree for the St Micro STV0991 board and enable device
tree control. We will progressively add device tree support to drivers
used by this board"

>
>>
>>> Signed-off-by: Vikas Manocha <vikas.manocha@st.com>
>>> ---
>>>  arch/arm/dts/Makefile     |    1 +
>>>  arch/arm/dts/stv0991.dts  |   23 +++++++++++++++++++++++
>>>  configs/stv0991_defconfig |    1 +
>>>  include/configs/stv0991.h |    3 +++
>>>  4 files changed, 28 insertions(+)
>>>  create mode 100644 arch/arm/dts/stv0991.dts
>>>
>>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>>> index 46a6171..86faf58 100644
>>> --- a/arch/arm/dts/Makefile
>>> +++ b/arch/arm/dts/Makefile
>>> @@ -54,6 +54,7 @@ dtb-$(CONFIG_SOCFPGA) +=                              \
>>>         socfpga_arria5_socdk.dtb                        \
>>>         socfpga_cyclone5_socdk.dtb                      \
>>>         socfpga_cyclone5_socrates.dtb
>>> +dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb
>> Is this the only chip in this soc family? If so fine. If not, could
>> your CONFIG be a little broader so we can (later) list all the DTBs
>> here?
>
> Yes, it is the only chip :-(, hope there will be more.

OK.

>
> Rgds,
> Vikas
>
>>>  dtb-$(CONFIG_LS102XA) += ls1021a-qds.dtb \
>>>         ls1021a-twr.dtb
>>> diff --git a/arch/arm/dts/stv0991.dts b/arch/arm/dts/stv0991.dts
>>> new file mode 100644
>>> index 0000000..b25c48b
>>> --- /dev/null
>>> +++ b/arch/arm/dts/stv0991.dts
>>> @@ -0,0 +1,23 @@
>>> +/dts-v1/;
>>> +
>>> +/ {
>>> +       model = "ST STV0991 application board";
>>> +       compatible = "st,stv0991";
>>> +       #address-cells = <1>;
>>> +       #size-cells = <1>;
>>> +
>>> +       chosen {
>>> +               stdout-path = &uart0;
>>> +       };
>>> +
>>> +       memory {
>>> +               device_type="memory";
>>> +               reg = <0x0 0x198000>;
>>> +       };
>>> +
>>> +       uart0: serial@0x80406000 {
>>> +               compatible = "arm,pl011", "arm,primecell";
>>> +               reg = <0x80406000 0x1000>;
>>> +               clock = <2700000>;
>>> +       };
>>> +};
>>> diff --git a/configs/stv0991_defconfig b/configs/stv0991_defconfig
>>> index 76ba41b..d9edc06 100644
>>> --- a/configs/stv0991_defconfig
>>> +++ b/configs/stv0991_defconfig
>>> @@ -5,3 +5,4 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000
>>>  CONFIG_ETH_DESIGNWARE=y
>>>  CONFIG_NETDEVICES=y
>>>  CONFIG_NET=y
>>> +CONFIG_DEFAULT_DEVICE_TREE="stv0991"
>>> diff --git a/include/configs/stv0991.h b/include/configs/stv0991.h
>>> index 2f65eda..750eebd 100644
>>> --- a/include/configs/stv0991.h
>>> +++ b/include/configs/stv0991.h
>>> @@ -80,4 +80,7 @@
>>>  #define CONFIG_AUTOBOOT_PROMPT                 \
>>>         "Hit SPACE in %d seconds to stop autoboot.\n", bootdelay
>>>  #undef CONFIG_HAS_VBAR
>>> +#define CONFIG_OF_EMBED
>>> +#define CONFIG_OF_CONTROL
>>> +#define CONFIG_OF_LIBFDT
>>>  #endif /* __CONFIG_H */
>>> --
>>> 1.7.9.5
>>>
>> Regards,
>> Simon
>

Regards,
Simon
diff mbox

Patch

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 46a6171..86faf58 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -54,6 +54,7 @@  dtb-$(CONFIG_SOCFPGA) +=				\
 	socfpga_arria5_socdk.dtb			\
 	socfpga_cyclone5_socdk.dtb			\
 	socfpga_cyclone5_socrates.dtb
+dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb
 
 dtb-$(CONFIG_LS102XA) += ls1021a-qds.dtb \
 	ls1021a-twr.dtb
diff --git a/arch/arm/dts/stv0991.dts b/arch/arm/dts/stv0991.dts
new file mode 100644
index 0000000..b25c48b
--- /dev/null
+++ b/arch/arm/dts/stv0991.dts
@@ -0,0 +1,23 @@ 
+/dts-v1/;
+
+/ {
+	model = "ST STV0991 application board";
+	compatible = "st,stv0991";
+	#address-cells = <1>;
+	#size-cells = <1>;
+
+	chosen {
+		stdout-path = &uart0;
+	};
+
+	memory {
+		device_type="memory";
+		reg = <0x0 0x198000>;
+	};
+
+	uart0: serial@0x80406000 {
+		compatible = "arm,pl011", "arm,primecell";
+		reg = <0x80406000 0x1000>;
+		clock = <2700000>;
+	};
+};
diff --git a/configs/stv0991_defconfig b/configs/stv0991_defconfig
index 76ba41b..d9edc06 100644
--- a/configs/stv0991_defconfig
+++ b/configs/stv0991_defconfig
@@ -5,3 +5,4 @@  CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_NETDEVICES=y
 CONFIG_NET=y
+CONFIG_DEFAULT_DEVICE_TREE="stv0991"
diff --git a/include/configs/stv0991.h b/include/configs/stv0991.h
index 2f65eda..750eebd 100644
--- a/include/configs/stv0991.h
+++ b/include/configs/stv0991.h
@@ -80,4 +80,7 @@ 
 #define CONFIG_AUTOBOOT_PROMPT                 \
 	"Hit SPACE in %d seconds to stop autoboot.\n", bootdelay
 #undef CONFIG_HAS_VBAR
+#define CONFIG_OF_EMBED
+#define CONFIG_OF_CONTROL
+#define CONFIG_OF_LIBFDT
 #endif /* __CONFIG_H */